1149285 - Add a DeserializedEdge gmock matcher and use it in the gtests for DeserializedNode's ubi::node

Status: RESOLVED FIXED

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Jim Blandy :jimb from bug 1024774 comment #167)
> @@ +63,5 @@
> > +    edge1.referent = referent1->id;
> > +    mocked.addEdge(Move(edge1));
> > +    EXPECT_CALL(mocked,
> > +                getEdgeReferent(Field(&DeserializedEdge::referent,
> > +                                      referent1->id)))
> 
> For the future, it'd be nice to add a DeserializedEdge matcher to
> DevTools.h. Then we could just say exactly what we mean.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Created attachment 8683877 [details] [diff] [review]
Abstract out edge matching with a custom gmock matcher

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96facaa9168c

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8683877 [details] [diff] [review]
Abstract out edge matching with a custom gmock matcher

Review of attachment 8683877 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/shared/heapsnapshot/tests/gtest/DeserializedNodeUbiNodes.cpp
@@ +64,5 @@
>                                                                     nullptr,
>                                                                     10));
>      DeserializedEdge edge1(referent1->id);
>      mocked.addEdge(Move(edge1));
> +    EXPECT_CALL(mocked, getEdgeReferent(EdgeTo(referent1->id)))

Whoa EXPECT_CALL is cool.

::: devtools/shared/heapsnapshot/tests/gtest/DevTools.h
@@ +280,5 @@
>  
> +// Matches an edge whose referent is the node with the given id.
> +MATCHER_P(EdgeTo, id, "") {
> +  return Matcher<const DeserializedEdge&>(Field(&DeserializedEdge::referent, id))
> +    .MatchAndExplain(arg, result_listener);

All of the code in here is gorgeous.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/55759fa6f9dc

Comment 5

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/55759fa6f9dc