1149290 - [Homescreen] The Smart Collection icon has broken spacing / alignment when adding it to a collapsed group

Status: RESOLVED DUPLICATE of bug 1149100

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150330_1314.txt

Description:
 When adding a smart collection to a collapsed group the smart collection icon is taking up 2x the appropriate width. The actual icon is to the right side of the area but the red X to delete app in edit mode is left justified. The hit box to launch the smart collection covers the entire area.

notes: This occurs when adding more than 1 smart collection at a time, but with some overlap: the 2nd collection will install twice as wide (with blank spot containing X and then icon) but the blank spot will overlap the first smart collection's icon, and run off the right side of the screen so the 2nd smart collection icon is hidden off-screen. 
Additionally, overlap of normal phone apps can occur when moving these 'too wide' icons around, causing icons and names to overlap.

Repro Steps:
1) Update a Flame to 20150330010204
2) Minimize a section of homescreen
3) Long press in the minimized section
4) Select and add a smart collection

Actual:
Smart Collection icon area is much wider than it should be

Expected:
Normal icon width and behavior


Environmental Variables:
Device: Flame 3.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150330010204
Gaia: be25b16efa19bab8d54be08f8fe45dcc93bf93d0
Gecko: dfe60814eda7
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0


Repro frequency: 9/9
See attached: logcat, video clip

Comment 1

[Joshua Mitchell (Inactive)]

This issue does NOT reproduce on Flame 2.2

Actual Results: Adding a smart collection to a collapsed group results in no irregular spacing

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150330002503
Gaia: 473cd63f53c855299b719285d9b95e3f2910782f
Gecko: 4b13c4254e2f
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional regression of homescreen

Requesting a window.

Comment 3

[Yeojin Chung [:YeojinC]]

b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150328011918
Gaia: cf833a2de70c53e4a4873659e0fe89601a25a1ea
Gecko: fa57eef78ac0
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150328033919
Gaia: 67ad91f3f660b1f16b354ee4c5159ddc5a74d149
Gecko: ac6e12a01113
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: cf833a2de70c53e4a4873659e0fe89601a25a1ea
Gecko: ac6e12a01113

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 67ad91f3f660b1f16b354ee4c5159ddc5a74d149
Gecko: fa57eef78ac0

https://github.com/mozilla-b2g/gaia/compare/cf833a2de70c53e4a4873659e0fe89601a25a1ea...67ad91f3f660b1f16b354ee4c5159ddc5a74d149

caused by bug 1146825

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Dale, can you take a look at this please? This looks to be caused by the landing for bug 1146825.

Comment 5

[Dale Harvey (:daleharvey)]

I believe this is a dupe of https://bugzilla.mozilla.org/show_bug.cgi?id=1149100. Checked the STR and cant with that applied