1149304 - reftest painting glitches when CSS transform is modified during the test

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Kew (:jfkthame)]

See the Windows XP failures in https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9dbc6d8dbf1. The ugly black bars visible in the testcase rendering should not exist; they appear to be an artifact of the transform changes.

Note that I do not see these artifacts when loading the testcase locally in my WinXP virtual machine. Possibly they are specific to running in the reftest framework; or possibly dependent on graphics hardware/drivers/etc.?

Note also that the problem does not occur on Windows 7 reftest jobs, either accelerated or unaccelerated; it seems to be specific to WinXP.

Comment 1

[Jonathan Kew (:jfkthame)]

Attachment: Reftest for repaint glitch when changing CSS transform (fails on WinXP)

Comment 2

[Jonathan Kew (:jfkthame)]

Attachment: Reftest for repaint issues when changing CSS transform

It turns out this test fails (in different ways) on OS X and Android, as well as the WinXP visual glitch. It looks OK when loading and comparing the testcase and reference locally, though; the problem seems to be specific to running in the reftest framework.

Comment 3

[Jonathan Kew (:jfkthame)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5c6da85599d

Comment 4

[Jonathan Kew (:jfkthame)]

Attachment: Mark test as failing on WinXP, OS X and Android

So until we figure out the problem(s) here, we'll need to mark the test as failing on specific platforms.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8586266 [details] [diff] [review]
Mark test as failing on WinXP, OS X and Android

Review of attachment 8586266 [details] [diff] [review]:
-----------------------------------------------------------------

You should just squash these patches together

Comment 6

[Jonathan Kew (:jfkthame)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43f8e1806067

Comment 7

[Jonathan Kew (:jfkthame)]

Apparently, the patch in bug 1149519 fixes the WinXP failure in this testcase, so I'm removing that part of the fails-if annotation along with that landing.

Comment 8

[Carsten Book [:Tomcat]]

backed this out for unexpected pass on android like https://treeherder.mozilla.org/logviewer.html#?job_id=8342592&repo=mozilla-inbound

Comment 9

[Jonathan Kew (:jfkthame)]

Apparently the failure on android-api-9 is not 100% reliable; we get occasional passes there, resulting in orange test runs.

In general, it looks like there's something timing-related about this, as though the reftest capture is happening before the testcase is really ready. (In the OS X failure, it's as though the transform changes haven't happened yet, even though the reftest-wait removal shouldn't happen until afterwards.)

:roc, do you see any reason the test should be unreliable in this way?

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't, unfortunately. The transformed element is probably being layerized, but that should be OK...

Comment 11

[Sylvestre Ledru [:Sylvestre]]

I guess we can close it?
Thanks

Comment 12

[Jonathan Kew (:jfkthame)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #11)
> I guess we can close it?

Better, we should try re-landing the reftest here, and see whether there are still failures on any current platform.

Pushed to try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ef0a04228601d3b6763ca61871ae9f9f4e071fc, let's see how that goes.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b434eb7d318a
Reftest for repaint issues when changing CSS transform. r=roc

Comment 14

[Jonathan Kew (:jfkthame)]

Try run looks OK. The issues that were causing failures 4 years ago may well have gotten fixed in the meantime. So provided the reftest sticks and doesn't start producing oranges, we can consider this resolved.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Merci!

Comment 16

[Bogdan Tara[:bogdan_tara]]

https://hg.mozilla.org/mozilla-central/rev/b434eb7d318a