Excessive creation of jQuery element of a star node

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: peterbe, Assigned: lfresh)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
See https://github.com/mozilla/airmozilla/blob/53a576b6ae2bf49647744bf39344bc5e9c659ba7/airmozilla/starred/static/starred/js/star_event.js#L36

We've already converted the DOM element into a jQuery element. So we should be able to re-use `$element`.

Comment 1

4 years ago
Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/eaf1b660a1c26af2df5c6f376466ab1dcaa121ac
Fixes bug 1149306 - Remove unnecessary creation of jQuery element

https://github.com/mozilla/airmozilla/commit/d1d68ea15df52274f828f529e5833405cd93525d
Merge pull request #263 from bugzPDX/1149306

Fixes bug 1149306 - Remove unnecessary jQuery element

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.