Closed Bug 1149319 Opened 9 years ago Closed 6 years ago

Define settings-link in HTML instead of in the translation

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Search
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: stas, Assigned: stas)

Details

Attachments

(1 file)

[gaia] stasm:1149319-settings-link > mozilla-b2g:master
46 bytes, text/x-github-pull-request
daleharvey
: review+
Details | Review 
Bug 1142526 made all innerHTML go through the DOM overlay logic and this means that the id="settings-link" defined in the translation will be filtered out.  It needs to be defined in the source HTML.
Attachment #8585740 - Flags: review?(dale)
Comment on attachment 8585740 [details] [review]
[gaia] stasm:1149319-settings-link > mozilla-b2g:master

Gave it a quick test and looks to be working nicely
Attachment #8585740 - Flags: review?(dale) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
https://github.com/mozilla-b2g/gaia/commit/069b19e5fe15af5ed14eb9a0d45dc018d8f2795d

backed out due to infra issues ( I will re-land )
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Just to make sure I understand: you're not changing the string ID because, if there's an id in localizations, it will be filtered out anyway by l10n.js?
Correct. Although I now realize that I could also simply remove the '.innerHTML' part. James, let me reland this with this tiny change once we've dealt with the infra problems.
Assignee: nobody → stas
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 9 years ago → 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: