1149383 - Flex containers with a vertical "writing-mode" will render with swapped width & height

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Right now, flex containers with a vertical "writing-mode" will render with swapped width & height. My reftests in bug 1148294 would've revealed this, except their flex containers are square, so the width<-->height swapping doesn't change the rendering.

I'm going to land a patch here to make those testcases use rectangular flex containers, so this issue becomes visible, and I'll mark the now-failing tests as 'fails' for the moment.

I'll leave this bug open until the issue is fixed; I've got a general refactoring patch that fixes this issue as part of making flex layout more logical-coordinate-focused.

Comment 1

[Daniel Holbert [:dholbert]]

Landed a patch to make the flex containers in these tests rectangular (and mark the tests with vertical writing-modes as failing now, because of that):
 https://hg.mozilla.org/integration/mozilla-inbound/rev/6a1b7c840e62

Also landed a second non-functional patch to make the width/height ordering consistent in these tests (width coming first):
 https://hg.mozilla.org/integration/mozilla-inbound/rev/f7e820f8572a

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6a1b7c840e62
https://hg.mozilla.org/mozilla-central/rev/f7e820f8572a

Comment 3

[Daniel Holbert [:dholbert]]

Bug 1158290 "part 5"* fixes these test-failures. (aside from the last two, which still fail due to bug 1131451)

needinfo=me to close this bug once that patch lands.

* attachment 8606132 [details] [diff] [review]

Comment 4

[Daniel Holbert [:dholbert]]

(Fixed by Bug 1158290 "part 5", per comment 3.)