Closed Bug 1149398 Opened 5 years ago Closed 5 years ago

Search UI dropdown menu shows search provider buttons even when no search terms have been entered

Categories

(Firefox :: Search, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED INVALID
Tracking Status
firefox37 --- affected
firefox38 --- affected
firefox39 --- affected
firefox40 --- affected
firefox-esr31 --- unaffected

People

(Reporter: cpeterson, Unassigned)

Details

(Keywords: regression, reproducible)

Florian, could this bug be a regression from bug 1113747?

If you open the search UI dropdown menu without entering any search terms, the dropdown menu shows the search provider buttons in addition to the "Change Search Settings" button. If you click one of the search provider buttons, Firefox searches for an empty string.

This is a regression in Firefox 38. Firefox 37 just shows the "Change Search Settings" button. I bisected this regression to this pushlog:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=56efbd155062&tochange=5de3af90c494
Dao, could this bug be a regression from bug 1113747? It doesn't seem like an intentional design decision.
Blocks: 1113747
Flags: needinfo?(dao)
This doesn't sound like a bug. You can also just hit Enter in the search bar with no search term entered. It brings you to the search engine's start page.
Flags: needinfo?(dao)
OK. On further thought, I see how it could be considered a feature. :)
No longer blocks: 1113747
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
(In reply to Chris Peterson [:cpeterson] from comment #0)

> I bisected this regression to this pushlog:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=56efbd155062&tochange=5de3af90c494

This contains "Bug 1126250 - Show one-off buttons when clicking the magnifying glass" where we implemented this behavior ;-).
You need to log in before you can comment on or make changes to this bug.