Closed
Bug 1149423
Opened 9 years ago
Closed 9 years ago
Add Windows timezone names to list of aliases
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
4.0.0.1
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
(Whiteboard: [timezone])
Attachments
(1 file)
15.49 KB,
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
As per bug 1086573 comment 30, I'm adding the Windows timezones from calendar/providers/gdata/modules/timezoneMap.jsm to the list of aliases. This is intended to be temporary, and I'll file a followup bug to fix the problem properly. I've also included the updates in 2015b: see https://mm.icann.org/pipermail/tz-announce/2015-March.txt
Updated•9 years ago
|
Whiteboard: [timezone]
Comment 1•9 years ago
|
||
Will this land in 4.0?
Comment 2•9 years ago
|
||
Comment on attachment 8585938 [details] [diff] [review] 2015b.diff Ah, forgot about this one, thanks for the comment. I'd be fine with taking it.
Attachment #8585938 -
Flags: review+
Attachment #8585938 -
Flags: approval-calendar-beta+
Attachment #8585938 -
Flags: approval-calendar-aurora+
Comment 3•9 years ago
|
||
Geoff, what are your thoughts? Any reason you didn't request review?
Blocks: ltn40
Flags: needinfo?(geoff)
Comment 4•9 years ago
|
||
I have some questions, When will 4.0b2 be released? Will this make the cut? At what point does it miss 4.0GA?
Comment 5•9 years ago
|
||
4.0b2 probably due Friday, final together with TB38. See https://wiki.mozilla.org/RapidRelease/Calendar for releases and merge dates. Usually betas every 6 weeks and real releases every ~42 weeks.
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Philipp Kewisch [:Fallen] from comment #3) > Geoff, what are your thoughts? Any reason you didn't request review? None that I can recall. Ship it.
Flags: needinfo?(geoff)
Keywords: checkin-needed
Comment 7•9 years ago
|
||
Pushed to comm-central changeset e2b3008f14cb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.1
Comment 8•9 years ago
|
||
Backported to releases/comm-aurora changeset 1ed0e357000e
Comment 9•9 years ago
|
||
Backported to releases/comm-beta changeset 2a06e201836b
Target Milestone: 4.1 → 4.0
Comment 10•4 years ago
|
||
(In reply to Geoff Lankow from comment #0)
As per bug 1086573 comment 30, I'm adding the Windows timezones from calendar/providers/gdata/modules/timezoneMap.jsm to the list of aliases. This is intended to be temporary, and I'll file a followup bug to fix the problem properly.
Is it still planned to remove the aliases? I notice that there are 36 entries in WindowsNTToZoneInfoTZId.properties
that aren't in the zones.json
. I was wondering whether they should be too, and (less importantly) why WindowsNTToZoneInfoTZId.properties
was created when the aliases could have been looked up in zones.json
in the first place.
You need to log in
before you can comment on or make changes to this bug.
Description
•