Closed
Bug 1149469
Opened 9 years ago
Closed 9 years ago
[Stingray][Home] Filtering cards by group
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rexboy, Assigned: dwi2)
References
Details
Attachments
(1 file)
As an user, I would like to filter out cards by category tab. We have 4 kinds of groups, namely TV, app, device, and dashboard. User can toggle a group and filter out cards that belong to that group.
Assignee | ||
Updated•9 years ago
|
Blocks: conn_priority
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → tzhuang
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8605665 [details] [review] [gaia] dwi2:bug1149469 > mozilla-b2g:master Hi Rex, Since this is not a small patch. I'd like to have your feedback first. In the mean time I am working on add unit tests for card_filter.js and filter_manager.js. Thanks
Attachment #8605665 -
Flags: feedback?(rexboy)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8605665 [details] [review] [gaia] dwi2:bug1149469 > mozilla-b2g:master It goes on a good direction. I haven't see tests in detail though. See some of my comments on Github.
Attachment #8605665 -
Flags: feedback?(rexboy) → feedback+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8605665 [details] [review] [gaia] dwi2:bug1149469 > mozilla-b2g:master Hi Rex, I've addressed your comments and added unit tests for filter_manager.js in two newer commits. Please help to review it. Thanks
Attachment #8605665 -
Flags: review?(rexboy)
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Tzu-Lin Huang [:dwi2][:tzhuang] from comment #4) > Comment on attachment 8605665 [details] [review] > [gaia] dwi2:bug1149469 > mozilla-b2g:master > > Hi Rex, > > I've addressed your comments and added unit tests for filter_manager.js in > two newer commits. Please help to review it. Thanks Sorry, it should be all in the latest commit.
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8605665 [details] [review] [gaia] dwi2:bug1149469 > mozilla-b2g:master Mostly looks good for me, But see my comments for some changes needed. Also please squash commits before landing.
Attachment #8605665 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Thanks, all comments are addressed. Waiting gaia-try result: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=49fa8807345d34de3e8579532d139644194c031b
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6fbb088da67e3efce11ab4d362e9bc972babe97e
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
You need to log in
before you can comment on or make changes to this bug.
Description
•