[Stingray][Home] Filtering cards by group

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: rexboy, Assigned: dwi2)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

As an user, I would like to filter out cards by category tab.

We have 4 kinds of groups, namely TV, app, device, and dashboard.
User can toggle a group and filter out cards that belong to that group.
(Assignee)

Updated

4 years ago
Blocks: 1146810
(Assignee)

Updated

4 years ago
Assignee: nobody → tzhuang
(Assignee)

Updated

4 years ago
See Also: → bug 1121348
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Depends on: 1162449
Created attachment 8605665 [details] [review]
[gaia] dwi2:bug1149469 > mozilla-b2g:master
(Assignee)

Comment 2

4 years ago
Comment on attachment 8605665 [details] [review]
[gaia] dwi2:bug1149469 > mozilla-b2g:master

Hi Rex,

Since this is not a small patch. I'd like to have your feedback first.
In the mean time I am working on add unit tests for card_filter.js and filter_manager.js.

Thanks
Attachment #8605665 - Flags: feedback?(rexboy)
Comment on attachment 8605665 [details] [review]
[gaia] dwi2:bug1149469 > mozilla-b2g:master

It goes on a good direction. I haven't see tests in detail though.

See some of my comments on Github.
Attachment #8605665 - Flags: feedback?(rexboy) → feedback+
(Assignee)

Comment 4

4 years ago
Comment on attachment 8605665 [details] [review]
[gaia] dwi2:bug1149469 > mozilla-b2g:master

Hi Rex,

I've addressed your comments and added unit tests for filter_manager.js in two newer commits. Please help to review it. Thanks
Attachment #8605665 - Flags: review?(rexboy)
(Assignee)

Comment 5

4 years ago
(In reply to Tzu-Lin Huang [:dwi2][:tzhuang] from comment #4)
> Comment on attachment 8605665 [details] [review]
> [gaia] dwi2:bug1149469 > mozilla-b2g:master
> 
> Hi Rex,
> 
> I've addressed your comments and added unit tests for filter_manager.js in
> two newer commits. Please help to review it. Thanks
Sorry, it should be all in the latest commit.
Comment on attachment 8605665 [details] [review]
[gaia] dwi2:bug1149469 > mozilla-b2g:master

Mostly looks good for me, But see my comments for some changes needed.
Also please squash commits before landing.
Attachment #8605665 - Flags: review?(rexboy) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 1166612
Whiteboard: [partner-cherry-pick]

Updated

3 years ago
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.