1149548 - keyword search from the location bar is now case sensitive - previously wasn't.

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Philip Chee]

STR:
1. create a bookmark like:
Name: Bugzilla Keyword Search
Location: https://bugzilla.mozilla.org/show_bug.cgi?id=%s
Keyword: bug

2. Type and enter: bug 1145063
3. Actual results: https://bugzilla.mozilla.org/show_bug.cgi?id=1145063
4. Type and enter: Bug 1145063
5. Actual results: https://www.google.com/search?q=Bug+1145063&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:unofficial&client=seamonkey-a

Comment 1

[Marco Bonardo [:mak]]

maybe a regression from bug 1125117?
It seems to be working for me though...

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Can't reproduce this either. Philip, can you check again?

Comment 3

[Philip Chee]

I should mention that I build and test SeaMonkey trunk almost every day. Is there anything in the front end code I need to change in SeaMonkey?

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Aha, so that's a SeaMonkey bug. Not aware of any frontend changes but Marco should know.

Comment 5

[Marco Bonardo [:mak]]

You should check your version of getShortcutOrURIAndPostData in browser probably (or whatever function you use to figure if words represent keywords or not)... I think all of the other changes are in the backend

Comment 6

[Philip Chee]

(In reply to Marco Bonardo [::mak] from comment #5)
> You should check your version of getShortcutOrURIAndPostData in browser
> probably (or whatever function you use to figure if words represent keywords
> or not)... I think all of the other changes are in the backend

Comment 7

[Marco Bonardo [:mak]]

actually, there's a bug here http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/PlacesUtils.jsm#948

The aKeyword should be lowercased in stmt.params.keyword = aKeyword;

This should fix your problem also if you don't immediately port the browser changes.

Comment 8

[Philip Chee]

Attachment: Patch fix getURLAndPostDataForKeyword

(In reply to Marco Bonardo [::mak] from comment #7)
> actually, there's a bug here
> http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/
> PlacesUtils.jsm#948
> 
> The aKeyword should be lowercased in stmt.params.keyword = aKeyword;
Thanks! I came to the same conclusion after staring at the code for a while.

> This should fix your problem also if you don't immediately port the browser
> changes.
This is on our radar but I don't know when we'll port the browser changes. Also [addon-compat]

Comment 9

[Marco Bonardo [:mak]]

(In reply to Philip Chee from comment #8)
> This is on our radar but I don't know when we'll port the browser changes.
> Also [addon-compat]

So far I made all new APIs be able to work along the old ones... clearly we can't keep the old ones forever, but surely we'll Deprecate.warning at least a couple versions before any removal.

Comment 10

[Marco Bonardo [:mak]]

note this fix is worth uplifting to Aurora.

Comment 11

[Philip Chee]

Try server results:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=86029fe3ce2a

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/3f9f9202ea64

Should we have a test for this?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3f9f9202ea64

Comment 14

[Philip Chee]

Comment on attachment 8587918 [details] [diff] [review]
Patch fix getURLAndPostDataForKeyword

Approval Request Comment
[Feature/regressing bug #]: Bug 1100294
[User impact if declined]: [addon-compat] The keyword used in urlbar searches is now unintentionally case sensitive for SeaMonkey and addons that use the old API.
[Describe test coverage new/current, TreeHerder]: current try server results are Green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7e8d67b2e37
[Risks and why]: low risk regression fix.
[String/UUID change made/needed]: none.

Comment 15

[Marco Bonardo [:mak]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #12)
> https://hg.mozilla.org/integration/fx-team/rev/3f9f9202ea64
> 
> Should we have a test for this?

we could but this code is deprecated.

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8587918 [details] [diff] [review]
Patch fix getURLAndPostDataForKeyword

Looks low risk, fixes a regression. Approving for uplift to aurora.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/768b8d2dada8