Closed
Bug 1149577
Opened 9 years ago
Closed 9 years ago
Remove history and recents affecting flags from TabQueueDispatcher entry in AndroidManifest
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mhaigh, Assigned: mhaigh)
References
Details
Attachments
(1 file)
1001 bytes,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
The nohistory and excludeFromRecents attributes in the TabQueueDispatcher entry in the AndroidManifest are incorrect and need to be removed as they affect the entire app when the TabQueueDispatcher is the entry point.
Assignee | ||
Comment 1•9 years ago
|
||
A bit of background - as opposed to hiding only the TabQueueDispatcher activity from the recents and history, it was actually hiding Fennec in it's entirety. Because we are calling finish() in the TabQueueDispatcher, it'll never appear in recents and can't be accessed via the back button.
Attachment #8586802 -
Flags: review?(michael.l.comella)
Attachment #8586802 -
Flags: review?(michael.l.comella) → review+
(In reply to Martyn Haigh (:mhaigh) from comment #1) > A bit of background - as opposed to hiding only the TabQueueDispatcher > activity from the recents and history, it was actually hiding Fennec in it's > entirety. Because we are calling finish() in the TabQueueDispatcher, it'll > never appear in recents and can't be accessed via the back button. By the way, I'd recommend adding these comments to version control rather than Bugzilla, but others may not agree because it's not as discoverable and not the typical way we do things. This may be somewhat alleviated with Reviewboard.
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/13c4aa8c1996
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/13c4aa8c1996
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•