Closed
Bug 1149590
Opened 9 years ago
Closed 9 years ago
Update/Upgrade for application dowloaded and installed, setting to ask/prompt for action ignored
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox37 | --- | unaffected |
firefox38 | --- | unaffected |
firefox39 | --- | fixed |
firefox40 | --- | fixed |
firefox-esr31 | --- | unaffected |
firefox-esr38 | --- | unaffected |
People
(Reporter: aryx, Assigned: robert.strong.bugs)
References
Details
(Keywords: regression)
Attachments
(3 files, 4 obsolete files)
1020 bytes,
patch
|
spohl
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
3.93 KB,
patch
|
spohl
:
review+
|
Details | Diff | Splinter Review |
4.81 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Firefox 39.0a1 and Thunderbird 39.0a1, both 20150330 on Windows 8.1 Both are set in Settings > Advanced > Update to check for updates, but prompt the user for the action (download & install or ignore). Open the application and let it idle. The download billboard will open after some time, download the update and tell you to restart to complete the installation [Tracking Requested - why for this release]: regression
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Did you download and install 39.0a1? If you did please provide a link to the Firefox download.
![]() |
Assignee | |
Comment 2•9 years ago
|
||
Also, Do you remember if you used a second profile at any point? If you did download and install please provide the steps you used.
Flags: needinfo?(archaeopteryx)
![]() |
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(archaeopteryx)
![]() |
Assignee | |
Comment 3•9 years ago
|
||
Figured out what the problem is
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8586242 -
Flags: review?(spohl.mozilla.bugs)
![]() |
Assignee | |
Updated•9 years ago
|
status-firefox38:
--- → ?
status-firefox39:
--- → affected
![]() |
Assignee | |
Updated•9 years ago
|
OS: Windows 8.1 → All
Hardware: x86 → All
Updated•9 years ago
|
Attachment #8586242 -
Flags: review?(spohl.mozilla.bugs) → review+
![]() |
Assignee | |
Comment 4•9 years ago
|
||
Pushed to fx-team https://hg.mozilla.org/integration/fx-team/rev/202034003fe1
tracking-firefox40:
? → ---
Target Milestone: --- → mozilla40
![]() |
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8586242 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: Bug 1137447 [User impact if declined]: B2G will auto update (the default is prompt in B2G) and desktop users will auto update when they have set their preference to notify. [Describe test coverage new/current, TreeHerder]: Manually tested and I am writing a test for in tree coverage. [Risks and why]: Minimal to none. This reverts a change made in Bug 1137447. [String/UUID change made/needed]: None
Attachment #8586242 -
Flags: approval-mozilla-aurora?
![]() |
Assignee | |
Updated•9 years ago
|
status-firefox37:
--- → unaffected
status-firefox-esr31:
--- → unaffected
status-firefox-esr38:
--- → unaffected
https://hg.mozilla.org/mozilla-central/rev/202034003fe1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8586242 [details] [diff] [review] patch Approving this for 39 since it looks low-risk and can affect updates.
Attachment #8586242 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
![]() |
Assignee | |
Comment 9•9 years ago
|
||
Pushed to mozilla-aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/cbfc7d6d54b7
![]() |
Assignee | |
Comment 10•9 years ago
|
||
Stephen, I verified this test works locally and here is a try run. I suspect that it will fail on gonk since gonk uses a custom nsIUpdatePrompt in which case I'll exclude gonk in the xpcshell.ini https://treeherder.mozilla.org/#/jobs?repo=try&revision=67fc983dc607
Attachment #8587792 -
Flags: review?(spohl.mozilla.bugs)
![]() |
Assignee | |
Comment 11•9 years ago
|
||
Forgot to use Assert in one place
Attachment #8587792 -
Attachment is obsolete: true
Attachment #8587792 -
Flags: review?(spohl.mozilla.bugs)
Attachment #8587797 -
Flags: review?(spohl.mozilla.bugs)
![]() |
Assignee | |
Comment 12•9 years ago
|
||
bah! I need to slow down... forgot to remove DEBUG_AUS_TEST!
Attachment #8587797 -
Attachment is obsolete: true
Attachment #8587797 -
Flags: review?(spohl.mozilla.bugs)
Attachment #8587798 -
Flags: review?(spohl.mozilla.bugs)
Updated•9 years ago
|
Attachment #8587798 -
Attachment is patch: true
![]() |
Assignee | |
Comment 13•9 years ago
|
||
Comment on attachment 8587798 [details] [diff] [review] test patch meh, crashes on Linux
Attachment #8587798 -
Attachment is obsolete: true
Attachment #8587798 -
Flags: review?(spohl.mozilla.bugs)
![]() |
Assignee | |
Comment 14•9 years ago
|
||
I think this should fix the crash (Stephen, sorry about the bug spam) Try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c69167d2459
![]() |
Assignee | |
Comment 15•9 years ago
|
||
Also pushed without the fix for this bug to check if it fails on all platforms, etc. https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d8c9bd800b5
![]() |
Assignee | |
Comment 16•9 years ago
|
||
Attachment #8587812 -
Attachment is obsolete: true
Attachment #8587868 -
Flags: review?(spohl.mozilla.bugs)
Comment 17•9 years ago
|
||
Comment on attachment 8587868 [details] [diff] [review] patch test Unfortunately, this seems to time out on B2G... https://treeherder.mozilla.org/logviewer.html#?job_id=6233132&repo=try
Attachment #8587868 -
Flags: review?(spohl.mozilla.bugs)
![]() |
Assignee | |
Comment 18•9 years ago
|
||
Comment on attachment 8587868 [details] [diff] [review] patch test Because of the custom nsIUpdatePrompt and I disabled it in b2g in the patch as shown below >diff --git a/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.ini b/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.ini >--- a/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.ini >+++ b/toolkit/mozapps/update/tests/unit_aus_update/xpcshell.ini >@@ -32,8 +32,11 @@ skip-if = toolkit != 'gonk' > skip-if = toolkit == 'gonk' > reason = custom nsIUpdatePrompt > [uiOnlyAllowOneWindow.js] > skip-if = toolkit == 'gonk' > reason = custom nsIUpdatePrompt > [uiUnsupportedAlreadyNotified.js] > skip-if = toolkit == 'gonk' > reason = custom nsIUpdatePrompt >+[uiAutoPref.js] >+skip-if = toolkit == 'gonk' >+reason = custom nsIUpdatePrompt
Attachment #8587868 -
Flags: review?(spohl.mozilla.bugs)
Comment 19•9 years ago
|
||
Ah, sorry. Missed comment 10. Thanks!
Comment 20•9 years ago
|
||
Comment on attachment 8587868 [details] [diff] [review] patch test Review of attachment 8587868 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/mozapps/update/tests/unit_aus_update/uiAutoPref.js @@ +87,5 @@ > + return { getInterface: XPCOMUtils.generateQI([Ci.nsIDOMWindow]) }; > + }, > + > + QueryInterface: XPCOMUtils.generateQI([Ci.nsIWindowMediator]) > +} nit: add ';' after '}'
Attachment #8587868 -
Flags: review?(spohl.mozilla.bugs) → review+
![]() |
Assignee | |
Comment 21•9 years ago
|
||
(In reply to Stephen Pohl [:spohl] from comment #20) > Comment on attachment 8587868 [details] [diff] [review] > patch test > > Review of attachment 8587868 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: toolkit/mozapps/update/tests/unit_aus_update/uiAutoPref.js > @@ +87,5 @@ > > + return { getInterface: XPCOMUtils.generateQI([Ci.nsIDOMWindow]) }; > > + }, > > + > > + QueryInterface: XPCOMUtils.generateQI([Ci.nsIWindowMediator]) > > +} > > nit: add ';' after '}' Forgot to do this. I'll fix that and other instances of the same in bug 1149276
![]() |
Assignee | |
Comment 22•9 years ago
|
||
Pushed test to fx-team https://hg.mozilla.org/integration/fx-team/rev/cfabb51c4a30
Flags: in-testsuite+
![]() |
Assignee | |
Comment 23•9 years ago
|
||
I'll uplift the test to aurora later
![]() |
Assignee | |
Comment 25•9 years ago
|
||
Pushed test to mozilla-aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/70b67abc4699
Test was failing on Aurora, backed it out at rstrong's request: https://hg.mozilla.org/releases/mozilla-aurora/rev/85071beda936 https://treeherder.mozilla.org/logviewer.html#?job_id=749079&repo=mozilla-aurora
![]() |
Assignee | |
Comment 28•9 years ago
|
||
Pushed fixed test patch to mozilla-aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/c4fb854ba5fe
You need to log in
before you can comment on or make changes to this bug.
Description
•