Closed
Bug 1149619
Opened 9 years ago
Closed 9 years ago
Possible race condition in Dispatcher#quitApplication
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-server)
Attachments
(1 obsolete file)
In Dispatcher#quitApplication, the closeSignal_ callback to shut down MarionetteServer (and its connections) is called before sendOk. This seems to work fine, but is a potential race condition. They should be switched, so that we first send the response and then clean up the connections.
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5840d3adb04
Assignee | ||
Comment 2•9 years ago
|
||
/r/6363 - Bug 1149619: Fix race in Dispatcher#quitApplication Pull down this commit: hg pull review -r 9ba66035a81f1638e7884b129cef05d4eb272c9b
Attachment #8586184 -
Flags: review?(dburns)
Assignee | ||
Comment 3•9 years ago
|
||
Examining MarionetteServer#stop it's clear that it only closes the _listener_, and doesn't end any existing socket connections. Therefore the current behaviour is correct. Thanks for :chmanchester for noticing!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Assignee | ||
Updated•9 years ago
|
Attachment #8586184 -
Attachment is obsolete: true
Attachment #8586184 -
Flags: review?(dburns)
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•