1149630 - fps graph should look more like other components in performance tools

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Especially in the dark theme, the FPS graph looks very different to everything else, aesthetically speaking.

Comment 1

[Tim Nguyen :ntim]

Instead of the current blue, you could use --theme-selection-background for both themes.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1149630-perf-graphs.patch

Perf graphs now use the same base graph, can style them by color. The tooltips still need to be redesigned but there's another bug for that.

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8587523 [details] [diff] [review]
1149630-perf-graphs.patch

Review of attachment 8587523 [details] [diff] [review]:
-----------------------------------------------------------------

Same thing, the colors are horrible imho. Hoping the other bug will make them better.

::: browser/devtools/performance/modules/performance-graphs.js
@@ +47,5 @@
> +  dampenValuesFactor: DAMPEN_VALUES,
> +  fixedHeight: HEIGHT,
> +  clipheadLineColor: CLIPHEAD_LINE_COLOR,
> +  selectionLineColor: SELECTION_LINE_COLOR,
> +  withTooltipArrows: false,

Don't we want arrows?

@@ +48,5 @@
> +  fixedHeight: HEIGHT,
> +  clipheadLineColor: CLIPHEAD_LINE_COLOR,
> +  selectionLineColor: SELECTION_LINE_COLOR,
> +  withTooltipArrows: false,
> +  withFixedTooltipPositions: true,

Fixed for both?

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Yeah, colors are bad. bgrins is landing bug 947242 that make it way pretty, but we will be tweeking it over the course of Fx40 (colors good for inspector text are probably not going to be the same as what will look good in a graph).

Regarding tooltip config, I think bug 1149626 will involve more styling, so will take care of it there if it makes sense one way or another to anchor the tooltips or what

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1149630-perf-graphs.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b0fea9629a8

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Intermittents in try for bug 1134500, but looks like that got handled

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/bcbdf1969c10

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bcbdf1969c10