fps graph should look more like other components in performance tools

RESOLVED FIXED in Firefox 40

Status

DevTools
Performance Tools (Profiler/Timeline)
RESOLVED FIXED
3 years ago
9 days ago

People

(Reporter: jsantell, Assigned: jsantell)

Tracking

37 Branch
Firefox 40
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Especially in the dark theme, the FPS graph looks very different to everything else, aesthetically speaking.
(Assignee)

Updated

3 years ago
Depends on: 1110550
(Assignee)

Updated

3 years ago
Assignee: nobody → jsantell
(Assignee)

Updated

3 years ago
Blocks: 1149846
(Assignee)

Updated

3 years ago
Depends on: 947242

Comment 1

3 years ago
Instead of the current blue, you could use --theme-selection-background for both themes.
Created attachment 8587523 [details] [diff] [review]
1149630-perf-graphs.patch

Perf graphs now use the same base graph, can style them by color. The tooltips still need to be redesigned but there's another bug for that.
Attachment #8587523 - Flags: review?(vporof)
Comment on attachment 8587523 [details] [diff] [review]
1149630-perf-graphs.patch

Review of attachment 8587523 [details] [diff] [review]:
-----------------------------------------------------------------

Same thing, the colors are horrible imho. Hoping the other bug will make them better.

::: browser/devtools/performance/modules/performance-graphs.js
@@ +47,5 @@
> +  dampenValuesFactor: DAMPEN_VALUES,
> +  fixedHeight: HEIGHT,
> +  clipheadLineColor: CLIPHEAD_LINE_COLOR,
> +  selectionLineColor: SELECTION_LINE_COLOR,
> +  withTooltipArrows: false,

Don't we want arrows?

@@ +48,5 @@
> +  fixedHeight: HEIGHT,
> +  clipheadLineColor: CLIPHEAD_LINE_COLOR,
> +  selectionLineColor: SELECTION_LINE_COLOR,
> +  withTooltipArrows: false,
> +  withFixedTooltipPositions: true,

Fixed for both?
Attachment #8587523 - Flags: review?(vporof) → review+
Yeah, colors are bad. bgrins is landing bug 947242 that make it way pretty, but we will be tweeking it over the course of Fx40 (colors good for inspector text are probably not going to be the same as what will look good in a graph).

Regarding tooltip config, I think bug 1149626 will involve more styling, so will take care of it there if it makes sense one way or another to anchor the tooltips or what
Intermittents in try for bug 1134500, but looks like that got handled
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Blocks: 1148822
https://hg.mozilla.org/integration/fx-team/rev/bcbdf1969c10
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/bcbdf1969c10
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40

Updated

9 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.