The latest release of mig-agent adds two modules (ping and timedrift), a better way for agents to discover their public API that doesn't rely on STUN, improvements to netstat discovery on OSX, and a couple of security fixes (none of them are dangerous to the host). The packages have been pushed to releng-puppet2.srv.releng.scl3.mozilla.com. Please merge, thanks! Changelog: Dustin J. Mitchell (3): [medium] Bug 104714: implement HasIPConnected on Darwin [minor] in netstat_darwin, use a global regexp rather than recompiling [minor] in netstat_darwin, return errors from parseEndpointString Julien Vehent (22): [medium] replace agent stun with api call to find its public ip [minor] don't respawn agent in debug mode [minor] store agent running mode in heartbeat & db [doc] clarify symlink behavior in file module [minor] dependency location update for osext package [minor] remove unused dependency in env_darwin [minor] remove unused dependency in env_windows [minor/bug] fix infinite loop in arp results parsing for windows and darwin [major/bug] prevent socket stat from locking agent results publication [minor] use float64 instead of strings to store latencies in ping module [minor] in ping module, map founanything to reachable [medium] ping module improvements: structs, logic and doc [minor] add file & netstat params validation to client tools [medium] timedrift module, to check that systems use network time [doc] Add timedrift module documentation [minor] in timedrift module, return foundanything=true only when time has drifted [minor] fix params parser of timedrift module [minor] gofmt on netstat module [minor] sleep 100ms between ping attempts to prevent floods [minor] add proxy support to public ip querying from agent [minor] timedrift ntp check stops at first good response [minor] set timedrift success to false if no ntp server was reachable Sushant Dinesh: [medium] ping module
Attachment #8586203 - Flags: review?(dustin)
Attachment #8586203 - Flags: review?(dustin) → review+
Please hold off on merging this patch, it's missing a config parameter.
Previous patches was missing a new config option used to detect the public IP of an endpoint. New patch adds that config option, and also enables public ip discovery in checkin mode. It was disabled because it relied on slow and buggy STUN queries. Now it's just a GET to the MIG API, so it's fine to enable everywhere.
Attachment #8587388 - Flags: review?(dustin) → review+
Comment on attachment 8587388 [details] [diff] [review] deploy patch with config change remote: https://hg.mozilla.org/build/puppet/rev/77e2a7efd9e2 remote: https://hg.mozilla.org/build/puppet/rev/be45292de713
Attachment #8587388 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.