Closed Bug 1149649 Opened 5 years ago Closed 5 years ago

Design Polish Updates for the Reader View Footer

Categories

(Firefox :: General, defect, P2)

38 Branch
defect
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 40
Iteration:
40.1 - 13 Apr
Tracking Status
firefox38 + fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: mmaslaney, Assigned: bwinton)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Couple Updates to fine tune the Footer


Adjust the box-shadow to:

• 0px 3px 3px -3px rgba(0, 0, 0,0.35) inset

(Currently, the footer seems rounded by the gradual gradient, we need to tighten it up)


• .Button should have a default color of #fbfbfb

• Dark Theme should use the same footer as light theme. Sepia is the only theme that should have a different footer
Attached patch The first cut at the patch. (obsolete) — Splinter Review
Here you go.

Screenshots at https://dl.dropboxusercontent.com/u/2301433/Firefox/Reading/FooterV3.png
Attachment #8586304 - Flags: ui-review?(mmaslaney)
Attachment #8586304 - Flags: review?(bmcbride)
Hi Blake, can you provide a point value.
Blocks: 1132074
Status: NEW → ASSIGNED
Iteration: --- → 40.1 - 13 Apr
Flags: qe-verify?
Flags: needinfo?(bwinton)
Flags: firefox-backlog+
Points: --- → 1
Flags: needinfo?(bwinton)
Attachment #8586304 - Flags: ui-review?(mmaslaney) → ui-review+
Comment on attachment 8586304 [details] [diff] [review]
The first cut at the patch.

Redirecting to Jaws…
Attachment #8586304 - Flags: review?(bmcbride) → review?(jaws)
Comment on attachment 8586304 [details] [diff] [review]
The first cut at the patch.

Review of attachment 8586304 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/themes/windows/global/aboutReader.css
@@ -268,5 @@
>  .toolbar .spacer {
>    color: white;
>    width: 40px;
>    background-position: center;
> -  background-color: #fbfbfb;

If you move `background-color`, you should move `color` with it.
Attachment #8586304 - Flags: review?(jaws) → review+
Note: Since having a background color of #fbfbfb and a color of white didn't make a lot of sense (but was unnoticeable before due to the buttons not having any text), I used the color from the remove button (#333), so that I didn't have to override it later.

Approval Request Comment
[Feature/regressing bug #]: readinglist
[User impact if declined]: The footer will be different from the spec, and not as nice looking.
[Describe test coverage new/current, TreeHerder]: Manual testing.
[Risks and why]: Low risk, due to exceedingly minor css changes.
[String/UUID change made/needed]: None.
Attachment #8586304 - Attachment is obsolete: true
Attachment #8588604 - Flags: ui-review+
Attachment #8588604 - Flags: review+
Attachment #8588604 - Flags: approval-mozilla-beta?
Attachment #8588604 - Flags: approval-mozilla-aurora?
Keywords: checkin-needed
Blake, no big deal, but if you are requesting the uplift to beta or aurora, you will get our attention.  Therefor, it is not needed to flag this bug for tracking.
Awesome!  Say, is there a page that says this sort of thing that I can look at next time?  (Because I'm sure I'll forget it by then.  :)
Target Milestone: Firefox 38 → ---
https://hg.mozilla.org/mozilla-central/rev/70e450e46efc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
(In reply to Blake Winton (:bwinton) from comment #7)
> Awesome!  Say, is there a page that says this sort of thing that I can look
> at next time?  (Because I'm sure I'll forget it by then.  :)

https://wiki.mozilla.org/Release_Management/Uplift_rules
https://wiki.mozilla.org/Release_Management/Tracking_rules
Attachment #8588604 - Flags: approval-mozilla-beta?
Attachment #8588604 - Flags: approval-mozilla-beta+
Attachment #8588604 - Flags: approval-mozilla-aurora?
Attachment #8588604 - Flags: approval-mozilla-aurora+
Should be in 38 beta 3
You need to log in before you can comment on or make changes to this bug.