1149677 - Minimum size for QR code display

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Currently the QR code is scaled to percent of the window size.  But on a small screen, it could be too small to scan well.

We should enforce some minimum size.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0001-Bug-1149677-Force-minimum-QR-code-size.-r-past.patch

Panos, does this make the QR code appear larger for you?

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc6f10093b77

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It may still be hard to scan, since the camera gets a low res picture...  still working on that front.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8587957 [details] [diff] [review]
0001-Bug-1149677-Force-minimum-QR-code-size.-r-past.patch

Review of attachment 8587957 [details] [diff] [review]:
-----------------------------------------------------------------

I managed to get a successful connection with this patch!

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

There are even more improvements coming soon, so I hope it will just get even better.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/76a06f930f3b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/76a06f930f3b