Closed
Bug 1149683
Opened 9 years ago
Closed 9 years ago
Allow long press on reader view icon to add to reading list
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: st3fan, Assigned: st3fan)
References
Details
Attachments
(1 file)
Parity with Android: Allow long press on reader view icon to add to reading list.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → sarentz
|
|
Assignee | |
Comment 1•9 years ago
|
||
This patch adds a long press gesture handler to the reading view button in the location bar. If pressed long, the page is added to the reading list. There is currently no feedback. Asking @darrinhenein and @tecgirl to give this a try and see if we need some kind of visual feedback. (How about a sound clip - of pages turning. Only half joking.)
Attachment #8588638 -
Flags: review?(bnicholson)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8588638 [details] [review] PR: https://github.com/mozilla/firefox-ios/pull/311 LGTM
Attachment #8588638 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 3•9 years ago
|
||
I filed a related https://bugzilla.mozilla.org/show_bug.cgi?id=1158503: "Adding item to Reading List by long-pressing Reader mode button issues no feedback" Some ideas for feedback form included there.
You need to log in
before you can comment on or make changes to this bug.
Description
•