114972 - Search context menu item should be visible but disabled even when text not selected

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect, P3)

Description

[Samir Gehani]

The search context menu item is currently only enabled when text is selected. 
The feature is not visible and as such should be available but disabled with
hintful text such as:

|  ___                             |
|  |d|  Search dmoz.org for "..."  |
|==================================|

Looking for input from Todd and Marlon.

Comment 1

[Samir Gehani]

Dan pointed the lack of visiblity of the feature (and this remedy reported
above) when he was reviewing some related code.  He is a user who has wanted the
search context menu item but didn't even know it was in the product... and he's
a mozilla developer!  

Comment 2

[Daniel Veditz [:dveditz]]

Right -- I don't often randomly click on a website before opening the context
menu to see if new items have shown up.  The presence of disabled items like
"Copy" has trained me not to expect the menu to change just because something is
selected.

Comment 3

[Todd Pringle]

The same thing happened to me too.  I didn't know it was already there because I
never saw the item.  I think this is the right solution for increasing
discoverablity of the feature even though it does add an additional context menu
item.  

Comment 4

[Samir Gehani]

Search triage team: nsbeta1+

Marlon, have we accounted for this in the new context menu spec?

Comment 5

[Samir Gehani]

Patch is part of fix for bug 106127.

Comment 6

[Blake Ross]

Marlon needs to make a decision and update the context menu spec before this
gets done, or I'm just going to remove it again with my patch...

Comment 7

[Samir Gehani]

Marlon,
Could you indicate if this is going to be part of the final context menu spec? 
I already have a patch but would be perfectly happy with leaving it out.  Need a
decision soon since drivers and ADT are cracking down on what gets checked in.

Comment 8

[Samir Gehani]

Got checked in with bug 106127.

Comment 9

[Claudius Gayle]

VERIFIED Fixed with 200020322 builds