If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

I was notified that my internet connection was down by Sync

RESOLVED FIXED in Firefox 39

Status

()

Firefox
Sync
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Gavin, Assigned: markh)

Tracking

Trunk
Firefox 40
Points:
1
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox38 affected, firefox39 fixed, firefox40 fixed)

Details

Attachments

(3 attachments)

My wifi was acting up earlier and I saw this notification bar:

https://cloudup.com/inuC82EdsNz

I don't think these should ever appear.
Created attachment 8586340 [details]
screenshot
I noticed this on mconley's livecoding stream too. Maybe something about the particular problem with Toronto wifi that causes this?
status-firefox40: affected → ---
(Assignee)

Comment 3

3 years ago
Hopefully we'd always see an error log in about:sync-log in this case - seeing such a log would probably help.
(Assignee)

Comment 4

3 years ago
Created attachment 8595314 [details]
Error logs

Some trimmed error logs - I think the notification bar came up in the first log.
(Assignee)

Comment 5

3 years ago
Created attachment 8596392 [details] [diff] [review]
0006-Bug-1149729-ignore-more-Sync-login-error-states.-r-a.patch

I could reproduce the problem during the login phase, trying to fetch a token. While we ignored errors during the actual sync, we failed to ignore them during login.

There's a logging change that isn't strictly related to this, but should help if we see this again in different circumstances.

This patch fixes that and includes tests.
Attachment #8596392 - Flags: review?(adw)
(Assignee)

Updated

3 years ago
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Points: --- → 1
status-firefox38: --- → affected
status-firefox39: --- → affected
status-firefox40: --- → affected
Flags: qe-verify-
Flags: firefox-backlog+

Updated

3 years ago
Iteration: --- → 40.2 - 27 Apr

Updated

3 years ago
Attachment #8596392 - Flags: review?(adw) → review+

Comment 6

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/105eaef4e0f1
https://hg.mozilla.org/mozilla-central/rev/105eaef4e0f1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
(Assignee)

Comment 8

2 years ago
Comment on attachment 8596392 [details] [diff] [review]
0006-Bug-1149729-ignore-more-Sync-login-error-states.-r-a.patch

It's not a critical problem, but we might as well try and get this into beta IMO.

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Sync may repeated nag that it isn't working when there's a network issue.
[Describe test coverage new/current, TreeHerder]: New tests.
[Risks and why]: Log risk limited to Sync error UI
[String/UUID change made/needed]: None
Attachment #8596392 - Flags: approval-mozilla-beta?
Attachment #8596392 - Flags: approval-mozilla-aurora?
Comment on attachment 8596392 [details] [diff] [review]
0006-Bug-1149729-ignore-more-Sync-login-error-states.-r-a.patch

We are late in the beta cycle. I don't think it is critical for the release. Not taking it.
Attachment #8596392 - Flags: approval-mozilla-beta?
Attachment #8596392 - Flags: approval-mozilla-beta-
Attachment #8596392 - Flags: approval-mozilla-aurora?
Attachment #8596392 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/fd5e167468d2
status-firefox39: affected → fixed
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.