Closed
Bug 1149778
Opened 9 years ago
Closed 9 years ago
ADB helper runtimes aren't loading properly
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(firefox37 unaffected, firefox38 fixed, firefox39 fixed, firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox37 | --- | unaffected |
firefox38 | --- | fixed |
firefox39 | --- | fixed |
firefox40 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
3.20 KB,
patch
|
jryans
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
ADB Helper's newer runtimes aren't loading, so WebIDE is falling back to old runtimes for things like Fennec. These don't really work anymore, so we need to get the new ones running again.
Assignee | ||
Updated•9 years ago
|
Blocks: dbg-fennec
Assignee | ||
Updated•9 years ago
|
Blocks: simulator-configuration
Keywords: regression
Assignee | ||
Updated•9 years ago
|
status-firefox39:
--- → affected
status-firefox40:
--- → affected
Assignee | ||
Updated•9 years ago
|
status-firefox38:
--- → affected
Assignee | ||
Updated•9 years ago
|
status-firefox37:
--- → unaffected
Assignee | ||
Comment 1•9 years ago
|
||
Changes from simulator profiles plus ADB Helper led to following problem: 1. ADB Helper inits at startup, calls require("devtools/webide/runtimes") 2. runtimes.js calls require("devtools/webide/simulators") 3. simulators.js calls require("devtools/webide/simulator-process") 4. simulator-process.js calls Services.appShell.hiddenDOMWindow But, |hiddenDOMWindow| does not exist yet, so an error is thrown, and ADB Helper can't finish init. I've made this chain lazier. Also, I filed bug 1149794 for ADB Helper to be lazier too.
Assignee | ||
Comment 2•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=61aadaa4d5c2
Comment 3•9 years ago
|
||
Comment on attachment 8586388 [details] [diff] [review] 0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch Review of attachment 8586388 [details] [diff] [review]: ----------------------------------------------------------------- Works fine here. ::: browser/devtools/webide/modules/simulator-process.js @@ +17,2 @@ > > +DevToolsUtils.defineLazyGetter(this, "OS", () => { Note that you have loader.lazyGetter. @@ +17,3 @@ > > +DevToolsUtils.defineLazyGetter(this, "OS", () => { > + switch (Runtime.OS) { small-nit: I'm wondering if it wouldn't be easier to just do let Runtime = require("sdk/system/runtime"); right here.
Attachment #8586388 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Fixed review comments. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4b22fcdf739
Attachment #8586388 -
Attachment is obsolete: true
Attachment #8586969 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/66a43444a517
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/66a43444a517
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8586969 [details] [diff] [review] 0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch Approval Request Comment [Feature/regressing bug #]: Bug 1090949 [User impact if declined]: WebIDE won't be able to connect to Firefox for Android devices [Describe test coverage new/current, TreeHerder]: No new tests, but on m-c [Risks and why]: Low, WebIDE only [String/UUID change made/needed]: None
Attachment #8586969 -
Flags: approval-mozilla-beta?
Attachment #8586969 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
Comment on attachment 8586969 [details] [diff] [review] 0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch should be in 38 beta 2
Attachment #8586969 -
Flags: approval-mozilla-beta?
Attachment #8586969 -
Flags: approval-mozilla-beta+
Attachment #8586969 -
Flags: approval-mozilla-aurora?
Attachment #8586969 -
Flags: approval-mozilla-aurora+
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•