Closed Bug 1149778 Opened 6 years ago Closed 6 years ago

ADB helper runtimes aren't loading properly

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(firefox37 unaffected, firefox38 fixed, firefox39 fixed, firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox37 --- unaffected
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

ADB Helper's newer runtimes aren't loading, so WebIDE is falling back to old runtimes for things like Fennec.

These don't really work anymore, so we need to get the new ones running again.
Changes from simulator profiles plus ADB Helper led to following problem:

1. ADB Helper inits at startup, calls require("devtools/webide/runtimes")
2. runtimes.js calls require("devtools/webide/simulators")
3. simulators.js calls require("devtools/webide/simulator-process")
4. simulator-process.js calls Services.appShell.hiddenDOMWindow

But, |hiddenDOMWindow| does not exist yet, so an error is thrown, and ADB Helper can't finish init.

I've made this chain lazier.  Also, I filed bug 1149794 for ADB Helper to be lazier too.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8586388 - Flags: review?(poirot.alex)
Comment on attachment 8586388 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

Review of attachment 8586388 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine here.

::: browser/devtools/webide/modules/simulator-process.js
@@ +17,2 @@
>  
> +DevToolsUtils.defineLazyGetter(this, "OS", () => {

Note that you have loader.lazyGetter.

@@ +17,3 @@
>  
> +DevToolsUtils.defineLazyGetter(this, "OS", () => {
> +  switch (Runtime.OS) {

small-nit: I'm wondering if it wouldn't be easier to just do
let Runtime = require("sdk/system/runtime"); right here.
Attachment #8586388 - Flags: review?(poirot.alex) → review+
https://hg.mozilla.org/mozilla-central/rev/66a43444a517
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Comment on attachment 8586969 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1090949
[User impact if declined]: WebIDE won't be able to connect to Firefox for Android devices
[Describe test coverage new/current, TreeHerder]: No new tests, but on m-c
[Risks and why]: Low, WebIDE only
[String/UUID change made/needed]: None
Attachment #8586969 - Flags: approval-mozilla-beta?
Attachment #8586969 - Flags: approval-mozilla-aurora?
Comment on attachment 8586969 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

should be in 38 beta 2
Attachment #8586969 - Flags: approval-mozilla-beta?
Attachment #8586969 - Flags: approval-mozilla-beta+
Attachment #8586969 - Flags: approval-mozilla-aurora?
Attachment #8586969 - Flags: approval-mozilla-aurora+
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.