ADB helper runtimes aren't loading properly

RESOLVED FIXED in Firefox 38

Status

RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

(Blocks: 1 bug, {regression})

unspecified
Firefox 40
regression
Dependency tree / graph

Firefox Tracking Flags

(firefox37 unaffected, firefox38 fixed, firefox39 fixed, firefox40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
ADB Helper's newer runtimes aren't loading, so WebIDE is falling back to old runtimes for things like Fennec.

These don't really work anymore, so we need to get the new ones running again.
(Assignee)

Updated

4 years ago
Blocks: 995671
(Assignee)

Updated

4 years ago
Blocks: 1090949
Keywords: regression
(Assignee)

Updated

4 years ago
status-firefox39: --- → affected
status-firefox40: --- → affected
(Assignee)

Updated

4 years ago
status-firefox38: --- → affected
(Assignee)

Updated

4 years ago
status-firefox37: --- → unaffected
(Assignee)

Comment 1

4 years ago
Created attachment 8586388 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

Changes from simulator profiles plus ADB Helper led to following problem:

1. ADB Helper inits at startup, calls require("devtools/webide/runtimes")
2. runtimes.js calls require("devtools/webide/simulators")
3. simulators.js calls require("devtools/webide/simulator-process")
4. simulator-process.js calls Services.appShell.hiddenDOMWindow

But, |hiddenDOMWindow| does not exist yet, so an error is thrown, and ADB Helper can't finish init.

I've made this chain lazier.  Also, I filed bug 1149794 for ADB Helper to be lazier too.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8586388 - Flags: review?(poirot.alex)
Comment on attachment 8586388 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

Review of attachment 8586388 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine here.

::: browser/devtools/webide/modules/simulator-process.js
@@ +17,2 @@
>  
> +DevToolsUtils.defineLazyGetter(this, "OS", () => {

Note that you have loader.lazyGetter.

@@ +17,3 @@
>  
> +DevToolsUtils.defineLazyGetter(this, "OS", () => {
> +  switch (Runtime.OS) {

small-nit: I'm wondering if it wouldn't be easier to just do
let Runtime = require("sdk/system/runtime"); right here.
Attachment #8586388 - Flags: review?(poirot.alex) → review+
(Assignee)

Comment 4

4 years ago
Created attachment 8586969 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

Fixed review comments.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4b22fcdf739
Attachment #8586388 - Attachment is obsolete: true
Attachment #8586969 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/66a43444a517
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/66a43444a517
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
(Assignee)

Comment 7

4 years ago
Comment on attachment 8586969 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1090949
[User impact if declined]: WebIDE won't be able to connect to Firefox for Android devices
[Describe test coverage new/current, TreeHerder]: No new tests, but on m-c
[Risks and why]: Low, WebIDE only
[String/UUID change made/needed]: None
Attachment #8586969 - Flags: approval-mozilla-beta?
Attachment #8586969 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

4 years ago
See Also: → bug 1100713
Comment on attachment 8586969 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

should be in 38 beta 2
Attachment #8586969 - Flags: approval-mozilla-beta?
Attachment #8586969 - Flags: approval-mozilla-beta+
Attachment #8586969 - Flags: approval-mozilla-aurora?
Attachment #8586969 - Flags: approval-mozilla-aurora+

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.