1149778 - ADB helper runtimes aren't loading properly

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

ADB Helper's newer runtimes aren't loading, so WebIDE is falling back to old runtimes for things like Fennec.

These don't really work anymore, so we need to get the new ones running again.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

Changes from simulator profiles plus ADB Helper led to following problem:

1. ADB Helper inits at startup, calls require("devtools/webide/runtimes")
2. runtimes.js calls require("devtools/webide/simulators")
3. simulators.js calls require("devtools/webide/simulator-process")
4. simulator-process.js calls Services.appShell.hiddenDOMWindow

But, |hiddenDOMWindow| does not exist yet, so an error is thrown, and ADB Helper can't finish init.

I've made this chain lazier.  Also, I filed bug 1149794 for ADB Helper to be lazier too.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=61aadaa4d5c2

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8586388 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

Review of attachment 8586388 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine here.

::: browser/devtools/webide/modules/simulator-process.js
@@ +17,2 @@
>  
> +DevToolsUtils.defineLazyGetter(this, "OS", () => {

Note that you have loader.lazyGetter.

@@ +17,3 @@
>  
> +DevToolsUtils.defineLazyGetter(this, "OS", () => {
> +  switch (Runtime.OS) {

small-nit: I'm wondering if it wouldn't be easier to just do
let Runtime = require("sdk/system/runtime"); right here.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

Fixed review comments.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4b22fcdf739

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/66a43444a517

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/66a43444a517

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8586969 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1090949
[User impact if declined]: WebIDE won't be able to connect to Firefox for Android devices
[Describe test coverage new/current, TreeHerder]: No new tests, but on m-c
[Risks and why]: Low, WebIDE only
[String/UUID change made/needed]: None

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8586969 [details] [diff] [review]
0001-Bug-1149778-Lazify-simulator-startup-to-allow-ADB-in.patch

should be in 38 beta 2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0290183ff4ad

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ecf15768ec50