Closed Bug 1149779 Opened 10 years ago Closed 10 years ago

Update issue modal to match original layout/styling

Categories

(Websites :: Shape of the Web, defect, P1)

Product:
Websites
Component:
Shape of the Web
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ckprice, Assigned: espressive)

Details

Original layout: http://cl.ly/image/3d2y0M1g2q2s (link: http://lorax.mkelly.me/detail/control/censorship) LEFT SIDE Headline Description Mozilla CTA | You CTA RIGHT SIDE all infographic Also, it looks like some font/font size has been updated
Also, there seems to be some issue with line height in headlines (http://cl.ly/image/0Y241Q391330).
(In reply to Cory Price [:ckprice] from comment #0) > Original layout: http://cl.ly/image/3d2y0M1g2q2s (link: > http://lorax.mkelly.me/detail/control/censorship) > > LEFT SIDE > > Headline > Description > Mozilla CTA | You CTA > > RIGHT SIDE > > all infographic > > Also, it looks like some font/font size has been updated In light of the discussion has with Holly and Greg, re: handling breakpoints for content, we do need to change the layout slightly: FULL WIDTH Headline Description LEFT SIDE Mozilla CTA | You CTA RIGHT SIDE Infographic At smaller breakpoints the layout will then be: FULL WIDTH Headline Description Mozilla CTA | You CTA Infographic Mozilla CTA Links | You CTA Links
Found a way to work around the above and still have the layout the way we want.
Commits pushed to master at https://github.com/mozilla/lorax https://github.com/mozilla/lorax/commit/d88178bafcffed9f935b9fedc08e54bd7359aec9 Fix Bug 1149779, update modal issue styling https://github.com/mozilla/lorax/commit/00fe4d4bd30d15bc2e79e93cfc7184c0ed292d5e Merge pull request #28 from schalkneethling/bug1149779-update-issue-modal-styling Fix Bug 1149779, update modal issue styling
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Not sure if this is temporary or a regression but I still see a lot of discrepancy in the layout and styling. Trying to point them all out here comparing with Work&Co's version: http://cl.ly/image/2S1G3N0T451i.
Creating a new bug for this.
You need to log in before you can comment on or make changes to this bug.