1149782 - Rewrite the test environment so Review Board runs inside Docker

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Gregory Szorc [:gps]]

This is needed so Autoland and Review Board can talk to one another.

This is the project I've been steadily working on for the past few weeks. I realize there wasn't a bug.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1149782/gps

/r/6377 - docker: support creating images via ansible playbook execution
/r/6385 - hgmo: better integrate Docker into Ansible roles
/r/6387 - hgrb: ansible support for running hg reviewboard servers
/r/6389 - mozreview: integrate hg-reviewboard container into MozReview environment
/r/6391 - mozreview: support for creating users in LDAP
/r/6393 - create default user ldap account during tests
/r/6395 - testing: overhaul the testing environment (bug 1149782)

Pull down these commits:

hg pull -r 891776ce25f627d996a1b12378d63d983f89cb96 https://reviewboard-hg.mozilla.org/version-control-tools/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8586376 [details]
MozReview Request: bz://1149782/gps

/r/6441 - mozreview: publish reviews before running fetchreviews
/r/6377 - docker: support creating images via ansible playbook execution
/r/6385 - hgmo: better integrate Docker into Ansible roles
/r/6387 - hgrb: ansible support for running hg reviewboard servers
/r/6389 - mozreview: integrate hg-reviewboard container into MozReview environment
/r/6391 - mozreview: support for creating users in LDAP
/r/6393 - create default user ldap account during tests
/r/6395 - testing: overhaul the testing environment (bug 1149782)

Pull down these commits:

hg pull -r d1f97ab36b09930c6ac7a2c001dc660c98bea851 https://reviewboard-hg.mozilla.org/version-control-tools/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8586376 [details]
MozReview Request: bz://1149782/gps

/r/6393 - testing: overhaul the testing environment (bug 1149782)

Pull down this commit:

hg pull -r fdbb1b48fd62af84eaacddcbf3b270901462657d https://reviewboard-hg.mozilla.org/version-control-tools/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8586376 [details]
MozReview Request: bz://1149782/gps

/r/6393 - testing: overhaul the testing environment (bug 1149782)

Pull down this commit:

hg pull -r 73e4210cde04cef90e3f3d78d0f368856d239537 https://reviewboard-hg.mozilla.org/version-control-tools/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8586376 [details]
MozReview Request: bz://1149782/gps

/r/6393 - testing: overhaul the testing environment (bug 1149782)

Pull down this commit:

hg pull -r 27cb5242ab89e72cf8ac084fa62630345a7f1584 https://reviewboard-hg.mozilla.org/version-control-tools/

Comment 6

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/6375/#review5605

Steven: I don't expect you to review this entire patch. Instead, I only ask that you look over the test changes and confirm they look sane.

Comment 7

[Steven MacLeod [:smacleod]]

Comment on attachment 8586376 [details]
MozReview Request: bz://1149782/gps

https://reviewboard.mozilla.org/r/6375/#review5659

LGTM, Ship-It!

::: ansible/roles/hg-reviewboard/templates/hg_helper.py.j2
(Diff revision 5)
> +        sys.stderr.write ('No interactive shells allowed here!\n') 

Trailing space.

::: ansible/roles/hg-reviewboard/templates/hg_helper.py.j2
(Diff revision 5)
> +        sys.stderr.write ('No interactive commands allowed here!\n') 

Trailing space.

::: ansible/roles/hg-reviewboard/templates/hg_helper.py.j2
(Diff revision 5)
> +        sys.stderr.write ('You are not welcome here, go away!\n') 

Trailing space.

::: ansible/roles/hg-reviewboard/templates/sh_helper.py.j2
(Diff revision 5)
> +            shlex.split(fixed_command_string[:command_end]), 

trailling.

::: ansible/roles/hg-reviewboard/templates/sh_helper.py.j2
(Diff revision 5)
> +        subcommand = subprocess.Popen(shlex.split(fixed_command_string), 

trailing.

::: docs/hacking-mozreview.rst
(Diff revision 5)
> -  Review Board URL: http://localhost:57486/
> -  Mercurial URL: http://localhost:57487/
> +  Bugzilla accessible on http://192.168.59.104:55568/
> +  Bugzilla URL: http://192.168.59.104:55568/

redundant?

::: docs/hacking-mozreview.rst
(Diff revision 5)
> +  Refresh code in the cluster by running:
> +    ./mozreview refresh
> +
> +  Perform refreshing automatically by running:
> +    ./mozreview autorefresh

This is excellent :)

::: docs/hacking-mozreview.rst
(Diff revision 5)
> +   This workflow is a bit complicated and should be improved.

Maybe some sort of wizard in the future? It *is* very nice we're mimicking production so much now! worth.

::: docs/hacking-mozreview.rst
(Diff revision 5)
> +   $ $(./mozreview shellinit)

awesome.

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8586376 [details]
MozReview Request: bz://1149782/gps

/r/6393 - testing: overhaul the testing environment (bug 1149782)

Pull down this commit:

hg pull -r 7f495c1398f1894e692d08322b8d62cd924726d9 https://reviewboard-hg.mozilla.org/version-control-tools/

Comment 9

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/49c4472806ea

Comment 10

[Gregory Szorc [:gps]]

This landed a few weeks ago.

Comment 12

[Gregory Szorc [:gps]]

Attachment: MozReview Request: docker: support creating images via ansible playbook execution

Comment 13

[Gregory Szorc [:gps]]

Attachment: MozReview Request: hgmo: better integrate Docker into Ansible roles

Comment 14

[Gregory Szorc [:gps]]

Attachment: MozReview Request: hgrb: ansible support for running hg reviewboard servers

Comment 15

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: integrate hg-reviewboard container into MozReview environment

Comment 16

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: support for creating users in LDAP

Comment 17

[Gregory Szorc [:gps]]

Attachment: MozReview Request: testing: overhaul the testing environment (bug 1149782)

Comment 18

[Gregory Szorc [:gps]]

Attachment: MozReview Request: testing: overhaul the testing environment (bug 1149782)

Comment 19

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: publish reviews before running fetchreviews