Closed Bug 1149872 Opened 5 years ago Closed 5 years ago

add the missing format specifiers

Categories

(Core :: General, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: juhsu, Assigned: theoneisneo)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

https://dxr.mozilla.org/mozilla-central/search?q=%5B%25%5D&case=true
add the missing format specifiers for the search results
Can you elaborate a bit more about what changes should be made here? Presumably in WebSocketChannel.cpp?
Hello Mike,
|LOG| may want to log the pointer of |this|, instead of printing |'%'|
Attached patch bug1149872.patchSplinter Review
Assignee: nobody → theoneisneo
Forget to push patch (facepalm)


Here's the right result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e74014611ae4
Attachment #8587241 - Flags: review?(daniel)
Comment on attachment 8587241 [details] [diff] [review]
bug1149872.patch

Review of attachment 8587241 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!
Attachment #8587241 - Flags: review?(daniel) → review+
Sheriffs: this patch is so trivial (just adds missing printf specifier) that it seems a waste to burn a try cycle on it.
Keywords: checkin-needed
Pushed this to try, since I was doing it anyway for another patch:

   https://treeherder.mozilla.org/#/jobs?repo=try&revision=71881f54fed2
https://hg.mozilla.org/mozilla-central/rev/b48f2db6a2bb
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.