add the missing format specifiers

RESOLVED FIXED in Firefox 40

Status

()

Core
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: junior, Assigned: TheOneisNEO)

Tracking

unspecified
mozilla40
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
https://dxr.mozilla.org/mozilla-central/search?q=%5B%25%5D&case=true
add the missing format specifiers for the search results

Comment 1

3 years ago
Can you elaborate a bit more about what changes should be made here? Presumably in WebSocketChannel.cpp?
(Reporter)

Comment 2

3 years ago
Hello Mike,
|LOG| may want to log the pointer of |this|, instead of printing |'%'|
(Assignee)

Comment 3

3 years ago
Created attachment 8587241 [details] [diff] [review]
bug1149872.patch
(Reporter)

Comment 4

3 years ago
Help to push to try server
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ae872e71c9a
(Reporter)

Updated

3 years ago
Assignee: nobody → theoneisneo
(Reporter)

Comment 5

3 years ago
Forget to push patch (facepalm)


Here's the right result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e74014611ae4
(Assignee)

Updated

3 years ago
Attachment #8587241 - Flags: review?(daniel)
Comment on attachment 8587241 [details] [diff] [review]
bug1149872.patch

Review of attachment 8587241 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!
Attachment #8587241 - Flags: review?(daniel) → review+
Sheriffs: this patch is so trivial (just adds missing printf specifier) that it seems a waste to burn a try cycle on it.
Keywords: checkin-needed
Pushed this to try, since I was doing it anyway for another patch:

   https://treeherder.mozilla.org/#/jobs?repo=try&revision=71881f54fed2

Comment 9

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b48f2db6a2bb
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b48f2db6a2bb
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.