Closed
Bug 1149872
Opened 9 years ago
Closed 9 years ago
add the missing format specifiers
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: CuveeHsu, Assigned: theoneisneo)
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
2.00 KB,
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/mozilla-central/search?q=%5B%25%5D&case=true add the missing format specifiers for the search results
Comment 1•9 years ago
|
||
Can you elaborate a bit more about what changes should be made here? Presumably in WebSocketChannel.cpp?
Reporter | ||
Comment 2•9 years ago
|
||
Hello Mike, |LOG| may want to log the pointer of |this|, instead of printing |'%'|
Assignee | ||
Comment 3•9 years ago
|
||
Reporter | ||
Comment 4•9 years ago
|
||
Help to push to try server https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ae872e71c9a
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → theoneisneo
Reporter | ||
Comment 5•9 years ago
|
||
Forget to push patch (facepalm) Here's the right result https://treeherder.mozilla.org/#/jobs?repo=try&revision=e74014611ae4
Assignee | ||
Updated•9 years ago
|
Attachment #8587241 -
Flags: review?(daniel)
Comment 6•9 years ago
|
||
Comment on attachment 8587241 [details] [diff] [review] bug1149872.patch Review of attachment 8587241 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch!
Attachment #8587241 -
Flags: review?(daniel) → review+
Comment 7•9 years ago
|
||
Sheriffs: this patch is so trivial (just adds missing printf specifier) that it seems a waste to burn a try cycle on it.
Keywords: checkin-needed
Comment 8•9 years ago
|
||
Pushed this to try, since I was doing it anyway for another patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=71881f54fed2
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b48f2db6a2bb
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•