1149938 - [Flame][Contacts]View the attached contact in New message view, it will enter edit view.

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Lancy(Leave from Mozilla)]

[1.Description]:
[Flame][v2.2&v3.0][Contacts]View the attached contact in New message view, it will enter edit view.
See attachments:Video.mp4 and logcat.txt
Ocuurence time:06:25


[2.Testing Steps]: 
Precondition:There are some contacts exist in Contacts app.
1.Launch Contacts.
2.View a contact and share it to message.
3.Tap the attached contact.


[3.Expected Result]: 
3.It should enter contact details view.

[4.Actual Result]: 
3.It will enter edit view.

[5.Reproduction build]: 
Flame 2.2 build (Affected):
Build ID               20150331162505
Gaia Revision          8b3086ad3963f1707e2bee9094baccafffe161c4
Gaia Date              2015-03-31 21:48:06
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/88e0e00cd64e
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150331.200333
Firmware Date          Tue Mar 31 20:03:44 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build (Affected):
Build ID               20150331160205
Gaia Revision          03164bd160809747e6a198e0dba1b7c3ee7789f5
Gaia Date              2015-03-31 14:48:14
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/18a8ea7c2c62
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150331.191641
Firmware Date          Tue Mar 31 19:16:50 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free Test

Comment 1

[Lancy(Leave from Mozilla)]

Attachment: logcat.txt

Comment 2

[Lancy(Leave from Mozilla)]

Attachment: Video.mp4

Comment 3

[Eric Chang [:ericcc] [:echang]]

Not sure this is in the spec or a bug, ni ux for confirmation.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Functionality introduced in bug 1113605.

Comment 5

[Maria Angeles Oteo (:oteo)]

As far as I remember this issue was already reported, fixed and verified in bug 1120878, but I am still reproducing it in master and 2.2 branches

Comment 6

[Adrián de la Rosa]

We implemented this in bug 1120878 by using the allowSave parameter in mozActivities. Since this is not a standard, mail decided there was a better way to solve it and started working on it. In the meantime, bug 1138371 was open so form view would open every time, allowing the user to at least save the contact.

The comments in the bugs I referenced are really helpful to understand what happened and why.

Comment 7

[Maria Angeles Oteo (:oteo)]

Thanks for clarifying it, Adrian!  
After implementing bug 1120878, if the contact was already included in the Agenda, the contact was opened with details view. In case it was a received a contact, not part of the Agenda, it was opened with form view giving to the user the option to save it. 

That was working fine for messaging application, but as the "allowSave" parameter was not implemented by E-mail app, and we need to a way to save received contacts via E-mail application (bug 1138371), the form view (edit) was decided to be used to view the vcards as workaround.

Comment 8

[Maria Angeles Oteo (:oteo)]

I am resolving the bug as Invalid as in bug 1138371 was decided to be implemented in that way to allow saving vcards from E-mail application.
We need to think if we want to maintain the same solution in 3.0 Release. Setting ni to Francisco to see what he thinks about it

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Once we have separated the views in documents, we could come with a documented and solid idea for what activities we will offer.