Closed Bug 1149967 Opened 9 years ago Closed 9 years ago

Time picker lags behind user input

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S9 (3apr)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: cwiiis, Assigned: cwiiis)

Details

(Keywords: polish, regression, Whiteboard: [systemsfe])

Attachments

(1 file)

[gaia] Cwiiis:bug1149967-laggy-time-picker > mozilla-b2g:master
46 bytes, text/x-github-pull-request
timdream
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
This is a long-standing bug that I've been meaning to file and fix for ages, so going to see if I can get this done before Friday so we can have it in 2.2.

There's a really awkward and distracting lag when dragging the wheels of the time-picker - it makes it very hard to actually pick the right time. This appears to be a regression from earlier versions of FxOS.

It looks like it's occurring because a transition style isn't being cleared during user input, so I expect this is easily fixed.
Ends up this is in system.
Component: Gaia::Components → Gaia::System
Comment on attachment 8586742 [details] [review]
[gaia] Cwiiis:bug1149967-laggy-time-picker > mozilla-b2g:master

Fix the bug and add a unit test to prevent regressions.
Attachment #8586742 - Flags: review?(timdream)
Nominating to block as it's a simple problem with a simple fix, and not fixing it makes setting the time on new calendar events and alarms much trickier than it needs to be.
blocking-b2g: --- → 2.2?
Just curious, is it the same issue as the bug 1129494 or is it a different issue?
Comment on attachment 8586742 [details] [review]
[gaia] Cwiiis:bug1149967-laggy-time-picker > mozilla-b2g:master

Thanks!
Attachment #8586742 - Flags: review?(timdream) → review+
I don't think this can be a blocker -- please re-non if you disagree.

Anyhow, you could always set approval‑gaia‑v2.2 once this lands on master -- regardless of the blocking status.
blocking-b2g: 2.2? → ---
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8586742 [details] [review]
[gaia] Cwiiis:bug1149967-laggy-time-picker > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Hard to pick dates/times in any date/time picker (e.g. in Clock when choosing an alarm time, or calendar when creating/editing an event)
[Testing completed]: Manual testing, also added a unit test to cover the regression
[Risk to taking this patch] (and alternatives if risky): Extremely low risk.
[String changes made]: None

It's quite close to the cut-off, but it'd be fantastic to have this in 2.2 - this is a tiny, low-risk change (2 lines) that markedly improves the UX of the date/time pickers (the current state of which is a regression from earlier releases).
Attachment #8586742 - Flags: approval-gaia-v2.2?
Attachment #8586742 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S9 (3apr)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: