1149971 - Fix problems caused by bug 1119878.

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Bob Owen (:bobowen)]

I didn't know about "ac_add_options --enable-ipdl-tests", so I broke the IPDL tests with my patches for bug 1119878.

As far as I can tell not all of these tests pass anyway in either ipc/ipdl/test/cxx or ipc/ipdl/test/ipdl at the moment.

Also the comment in "ipc/ipdl/test/moz.build" suggests that the compiler tests run normally, but I think they are excluded by the moz.build in the parent directory.

I also got an email saying I'd increased the "Number of Constructors" from 85 to 265.
I'm pretty sure this is talking about static initializers and it is because of kCurrentProcessId being defined in a header that is included all over the place (including generated code).

Comment 1

[Bob Owen (:bobowen)]

try: -b do -p linux64,win32 -u reftest-e10s,crashtest-e10s,mochitests -t none

Comment 2

[Bob Owen (:bobowen)]

Attachment: Part 1: Follow-up to bug 1119878 to fix broken IPDL tests.

Comment 3

[Bob Owen (:bobowen)]

Attachment: Part 2: Cet rid of kCurrentProcessId as it makes lots of static initializers.

Comment 4

[Bob Owen (:bobowen)]

Comment on attachment 8586852 [details] [diff] [review]
Part 1: Follow-up to bug 1119878 to fix broken IPDL tests.

The only bit I'm not sure about here is the replacing of the two |OtherProcess() != 0|.

As I don't think that could have happened with the old code.
It would have been kInvalidProcessHandle (i.e. -1).

Comment 5

[Bob Owen (:bobowen)]

Comment on attachment 8586853 [details] [diff] [review]
Part 2: Cet rid of kCurrentProcessId as it makes lots of static initializers.

This is a straight forward replacement.

Comment 6

[Bob Owen (:bobowen)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/4917154135d8
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/efe9fa6820b4

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4917154135d8
https://hg.mozilla.org/mozilla-central/rev/efe9fa6820b4