Closed Bug 1149988 Opened 8 years ago Closed 6 years ago

Add to reading list icon in reader view sidebar lacks context and is heavy compared to other icons

Categories

(Toolkit :: Reader Mode, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: phlsa, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

Attached image proposal (obsolete) —
The current icons for adding and removing items from the reading list from reader view have two issues:

- It communicates "adding" without giving any indication on what the article will be added to
- It looks much heavier visually than the icons above and below

Attached is a very crappy mockup of a possible direction.
Attached image Proposal
Here's a higher quality version.
What do you think Michael?
Attachment #8586746 - Attachment is obsolete: true
Attachment #8587389 - Flags: ui-review?(mmaslaney)
Comment on attachment 8587389 [details]
Proposal

I share your sentiment entirely. 

We'll need to get these asset in SVG format for Blake and team.

Could you file an engineering bug and assign it to a Mr. Blake Winton. He'll need to update the URL and Reader View Icons. We should also make sure it matches the size of the Reader View icon in the URL bar.
Attachment #8587389 - Flags: ui-review?(mmaslaney) → ui-review+
(In reply to Michael Maslaney [:mmaslaney] (mmaslaney@mozilla.com) from comment #2)
> Could you file an engineering bug and assign it to a Mr. Blake Winton. He'll
> need to update the URL and Reader View Icons. We should also make sure it
> matches the size of the Reader View icon in the URL bar.

I'd like to note that the UI Tour text has already landed and it references a "plus button". Here is the text for the UITour panel that will point to the URL bar's reader mode button:

"Click the book to make articles easier to read and use the plus to save them for later."

This text ^ cannot be changed for Firefox 38 or 39.
Flags: needinfo?(philipp)
Flags: needinfo?(mmaslaney)
(In reply to Michael Maslaney [:mmaslaney] (mmaslaney@mozilla.com) from comment #2)
> Could you file an engineering bug and assign it to a Mr. Blake Winton. He'll
> need to update the URL and Reader View Icons. We should also make sure it
> matches the size of the Reader View icon in the URL bar.

Can we test this out in the URL bar?  I'm a bit concerned about the size and similarity of the reader view and add to reading list icons there.  If I understand correctly we could have a book icon with a small plus beside a book icon. :-\

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> I'd like to note that the UI Tour text has already landed and it references
> a "plus button". Here is the text for the UITour panel that will point to
> the URL bar's reader mode button:
> 
> "Click the book to make articles easier to read and use the plus to save
> them for later."
> 
> This text ^ cannot be changed for Firefox 38 or 39.

Unless we can find an acceptable path forward with the strings we have I think we should consider this change for after 39.
Let's punt this to for after 39. It's a little to late to make this type of change.
Flags: needinfo?(mmaslaney)
Just to be clear, I was talking about only changing the (large) icon in the reader view toolbar, not the one in the URL bar.
The idea was to use the same plus icon, but add the book for context.

That would also mean that the tour text would still work.

There's the question around consistency though.
Summary: Add to reading list icon in reader view lacks context and is heavy compared to other icons → Add to reading list icon in reader view sidebar lacks context and is heavy compared to other icons
No more reading list icon --> invalid.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.