Closed Bug 1150005 Opened 6 years ago Closed 6 years ago

Intermittent browser_styleeditor_fetch-from-cache.js | Test timed out - expected PASS

Categories

(DevTools :: Style Editor, defect)

x86
Linux
defect
Not set
normal

Tracking

(firefox38 unaffected, firefox39 fixed, firefox40 fixed, firefox-esr31 unaffected)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox38 --- unaffected
firefox39 --- fixed
firefox40 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: cbook, Assigned: sjakthol)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Ubuntu VM 12.04 x64 mozilla-inbound pgo test mochitest-e10s-devtools-chrome

https://treeherder.mozilla.org/logviewer.html#?job_id=8349312&repo=mozilla-inbound

05:59:55 INFO - 5326 INFO TEST-UNEXPECTED-FAIL | browser/devtools/styleeditor/test/browser_styleeditor_fetch-from-cache.js | Test timed out - expected PASS
The "editor-selected" event might occur before initialization is complete and thus the test waits for an event that has already been emitted.

The patch replaces the event with getSourceEditor which resolves immediately if the selection has completed and waits for it to complete otherwise.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dcb390b2ad0f
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8591195 - Flags: review?(bgrinstead)
Comment on attachment 8591195 [details] [diff] [review]
bug-1150005-fetch-from-cache-timeout.patch

Review of attachment 8591195 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good
Attachment #8591195 - Flags: review?(bgrinstead) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/f29e1629564d
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f29e1629564d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
These test fixes I've worked on applies only up to Aurora as bug 1147765 landed the bits and pieces required for these to work.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.