Closed
Bug 1150005
Opened 8 years ago
Closed 8 years ago
Intermittent browser_styleeditor_fetch-from-cache.js | Test timed out - expected PASS
Categories
(DevTools :: Style Editor, defect)
Tracking
(firefox38 unaffected, firefox39 fixed, firefox40 fixed, firefox-esr31 unaffected)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox38 | --- | unaffected |
firefox39 | --- | fixed |
firefox40 | --- | fixed |
firefox-esr31 | --- | unaffected |
People
(Reporter: cbook, Assigned: sjakthol)
References
()
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.35 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
Ubuntu VM 12.04 x64 mozilla-inbound pgo test mochitest-e10s-devtools-chrome https://treeherder.mozilla.org/logviewer.html#?job_id=8349312&repo=mozilla-inbound 05:59:55 INFO - 5326 INFO TEST-UNEXPECTED-FAIL | browser/devtools/styleeditor/test/browser_styleeditor_fetch-from-cache.js | Test timed out - expected PASS
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
![]() |
Assignee | |
Comment 4•8 years ago
|
||
The "editor-selected" event might occur before initialization is complete and thus the test waits for an event that has already been emitted. The patch replaces the event with getSourceEditor which resolves immediately if the selection has completed and waits for it to complete otherwise. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dcb390b2ad0f
Comment 5•8 years ago
|
||
Comment on attachment 8591195 [details] [diff] [review] bug-1150005-fetch-from-cache-timeout.patch Review of attachment 8591195 [details] [diff] [review]: ----------------------------------------------------------------- Looks good
Attachment #8591195 -
Flags: review?(bgrinstead) → review+
![]() |
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f29e1629564d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Comment 9•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2f7ea2e1f1ad
status-firefox39:
--- → fixed
Updated•8 years ago
|
status-firefox38:
--- → affected
status-firefox-esr31:
--- → unaffected
Comment 11•8 years ago
|
||
Leaks on beta. *shrug* https://hg.mozilla.org/releases/mozilla-beta/rev/4f36d5aff5cf
![]() |
Assignee | |
Comment 12•8 years ago
|
||
These test fixes I've worked on applies only up to Aurora as bug 1147765 landed the bits and pieces required for these to work.
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•