Review Revision page should contain all unapproved revisions comment

RESOLVED FIXED

Status

support.mozilla.org
Knowledge Base Software
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: safwan, Assigned: safwan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Referenced Bug 1112507:
Fixing Bug 699658 and Bug 1112507 started showing Revision comments in the Review page for All locals. But it only shows the comment of the revision being reviewed, we need previous comments as well until the revision marked "current".

Here is how it should look like: http://note.io/1qkVZ9b
(Assignee)

Updated

3 years ago
See Also: → bug 1112507
Safwan and I chatted about this on irc. Let's display up to 5 most recent unreviewed revision comments.
(Assignee)

Comment 2

3 years ago
Created attachment 8610757 [details] [review]
Proposed Patch
(Assignee)

Updated

3 years ago
Assignee: nobody → safwan.rahman15
Status: NEW → ASSIGNED
Landed:
https://github.com/mozilla/kitsune/commit/368cd46d9a64d909fdc4f15bcda9787496ac51b8

Pushed to prod by me, right now.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

3 years ago
Topal, Can you please check if its working as you expected in Bug 696658?
Flags: needinfo?(a.topal)
Yes, thanks, Safwan!
Flags: needinfo?(a.topal)

Updated

2 years ago
See Also: → bug 1235806
You need to log in before you can comment on or make changes to this bug.