Closed Bug 1150036 Opened 7 years ago Closed 6 years ago
[e10s] Crash and leak when running browser
_tab _dragdrop .js in debug mode
mach mochitest-browser --e10s browser_tab_dragdrop.js The test log is attached. Note the leak and: TEST-INFO | leakcheck | missing output line from log file /tmp/tmp6OtNb5.mozrunner/runtests_leaks_plugin_pid15293.log
Jim, you might have some interest in this bug, although it may not be important.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Try push, passing with no leaks or crashes on win32/win64 debug builds. https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cfca1defe6a
Review commit: https://reviewboard.mozilla.org/r/42021/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42021/
Attachment #8733920 - Flags: review?(felipc)
Comment on attachment 8733920 [details] MozReview Request: Bug 1150036 - Fix leaks within browser_tab_dragdrop.js by making sure references to tabs are deleted and message listeners are removed. r?felipe https://reviewboard.mozilla.org/r/42021/#review38845 ::: dom/plugins/test/testplugin/README:127 (Diff revision 1) > arguments passed to the method. > > * .crash() - Crashes the plugin > > * getObjectValue() - Returns a custom plugin-implemented scriptable object. > -* checkObjectValue(obj) - Returns true if the object from setObjectValue() is > +* checkObjectValue(obj) - Returns true if the object from getObjectValue() is is this part of this patch?
Attachment #8733920 - Flags: review?(felipc) → review+
https://reviewboard.mozilla.org/r/42021/#review38845 > is this part of this patch? Yeah it is. There is no setObjectValue, so this is a typo.
This test is still being skipped with an annotation pointing at this bug. Was that on purpose?
Pushed to tryserver with the test enabled on e10s debug builds, https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ac59f63cad93b0c0c27cd65c703a9b26283ce31
test passing on tryserver, filed bug 1312436 to get the test enabled.
You need to log in before you can comment on or make changes to this bug.