1150036 - [e10s] Crash and leak when running browser_tab_dragdrop.js in debug mode

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: test output

mach mochitest-browser --e10s browser_tab_dragdrop.js

The test log is attached. Note the leak and:
TEST-INFO | leakcheck | missing output line from log file /tmp/tmp6OtNb5.mozrunner/runtests_leaks_plugin_pid15293.log

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Jim, you might have some interest in this bug, although it may not be important.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Try push, passing with no leaks or crashes on win32/win64 debug builds.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cfca1defe6a

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: MozReview Request: Bug 1150036 - Fix leaks within browser_tab_dragdrop.js by making sure references to tabs are deleted and message listeners are removed. r?felipe

Review commit: https://reviewboard.mozilla.org/r/42021/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42021/

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8733920 [details]
MozReview Request: Bug 1150036 - Fix leaks within browser_tab_dragdrop.js by making sure references to tabs are deleted and message listeners are removed. r?felipe

https://reviewboard.mozilla.org/r/42021/#review38845

::: dom/plugins/test/testplugin/README:127
(Diff revision 1)
>  arguments passed to the method.
>  
>  * .crash() - Crashes the plugin
>  
>  * getObjectValue() - Returns a custom plugin-implemented scriptable object.
> -* checkObjectValue(obj) - Returns true if the object from setObjectValue() is
> +* checkObjectValue(obj) - Returns true if the object from getObjectValue() is

is this part of this patch?

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://reviewboard.mozilla.org/r/42021/#review38845

> is this part of this patch?

Yeah it is. There is no setObjectValue, so this is a typo.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5f4aa4f69c2

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e5f4aa4f69c2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This test is still being skipped with an annotation pointing at this bug. Was that on purpose?

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Pushed to tryserver with the test enabled on e10s debug builds,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ac59f63cad93b0c0c27cd65c703a9b26283ce31

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

test passing on tryserver, filed bug 1312436 to get the test enabled.