Closed Bug 1150036 Opened 7 years ago Closed 6 years ago

[e10s] Crash and leak when running browser_tab_dragdrop.js in debug mode

Categories

(Core Graveyard :: Plug-ins, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(e10s+, firefox40 affected, firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox40 --- affected
firefox48 --- fixed

People

(Reporter: billm, Assigned: jaws)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached file test output
mach mochitest-browser --e10s browser_tab_dragdrop.js

The test log is attached. Note the leak and:
TEST-INFO | leakcheck | missing output line from log file /tmp/tmp6OtNb5.mozrunner/runtests_leaks_plugin_pid15293.log
Jim, you might have some interest in this bug, although it may not be important.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Try push, passing with no leaks or crashes on win32/win64 debug builds.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cfca1defe6a
Comment on attachment 8733920 [details]
MozReview Request: Bug 1150036 - Fix leaks within browser_tab_dragdrop.js by making sure references to tabs are deleted and message listeners are removed. r?felipe

https://reviewboard.mozilla.org/r/42021/#review38845

::: dom/plugins/test/testplugin/README:127
(Diff revision 1)
>  arguments passed to the method.
>  
>  * .crash() - Crashes the plugin
>  
>  * getObjectValue() - Returns a custom plugin-implemented scriptable object.
> -* checkObjectValue(obj) - Returns true if the object from setObjectValue() is
> +* checkObjectValue(obj) - Returns true if the object from getObjectValue() is

is this part of this patch?
Attachment #8733920 - Flags: review?(felipc) → review+
https://reviewboard.mozilla.org/r/42021/#review38845

> is this part of this patch?

Yeah it is. There is no setObjectValue, so this is a typo.
https://hg.mozilla.org/mozilla-central/rev/e5f4aa4f69c2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
This test is still being skipped with an annotation pointing at this bug. Was that on purpose?
Flags: needinfo?(jaws)
Depends on: 1312436
test passing on tryserver, filed bug 1312436 to get the test enabled.
Flags: needinfo?(jaws)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.