1150066 - Restore ability to run prepare_tlds.py standalone

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gervase Markham [:gerv]]

Bug 883954 removed the ability to run e.g.

python ./netwerk/dns/prepare_tlds.py netwerk/dns/effective_tld_names.dat

The team which maintains the effective_tld_names.dat file uses this as a sanity check to make sure we haven't screwed up the syntax. So we'd like that ability back, please.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Comment 2

[Nathan Froyd [:froydnj]]

Does:

  make etld_data.inc

work for your purposes?  I know it's something new, but it at least does the same thing?

Comment 3

[Gervase Markham [:gerv]]

Run where? Doesn't seem to work at the top level, or any of the intermediate ones down to netwerk/dns.

What I'd like, ideally, is a way to run this sanity check over the script without having to build Firefox.

Gerv

Comment 4

[Nathan Froyd [:froydnj]]

WFM in netwerk/dns/:

[froydnj@cerebro git-bz-moz]$ cd /opt/build/froydnj/build-mc/netwerk/dns/
[froydnj@cerebro dns]$ make etld_data.inc 
make: 'etld_data.inc' is up to date.
[froydnj@cerebro dns]$ 

But being able to run the script without configuring Firefox et al is a reasonable thing to want, and it looks like that's easily achievable.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5efa282fa7f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d5efa282fa7f