Closed Bug 1150066 Opened 7 years ago Closed 7 years ago

Restore ability to run prepare_tlds.py standalone

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gerv, Assigned: gerv)

Details

Attachments

(1 file)

Bug 883954 removed the ability to run e.g.

python ./netwerk/dns/prepare_tlds.py netwerk/dns/effective_tld_names.dat

The team which maintains the effective_tld_names.dat file uses this as a sanity check to make sure we haven't screwed up the syntax. So we'd like that ability back, please.

Gerv
Attached patch Patch v.1Splinter Review
Attachment #8586830 - Flags: review?(gps)
Does:

  make etld_data.inc

work for your purposes?  I know it's something new, but it at least does the same thing?
Run where? Doesn't seem to work at the top level, or any of the intermediate ones down to netwerk/dns.

What I'd like, ideally, is a way to run this sanity check over the script without having to build Firefox.

Gerv
WFM in netwerk/dns/:

[froydnj@cerebro git-bz-moz]$ cd /opt/build/froydnj/build-mc/netwerk/dns/
[froydnj@cerebro dns]$ make etld_data.inc 
make: 'etld_data.inc' is up to date.
[froydnj@cerebro dns]$ 

But being able to run the script without configuring Firefox et al is a reasonable thing to want, and it looks like that's easily achievable.
Attachment #8586830 - Flags: review?(gps) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.