115007 - SVG-enabled static builds break in final link

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[hacker formerly known as [e-mail]]

Comment 1

[hacker formerly known as [e-mail]]

(I *really* hate that <Enter> == form submit feature)

Index: xpfe/bootstrap/Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/xpfe/bootstrap/Makefile.in,v
retrieving revision 1.149
diff -u -r1.149 Makefile.in
--- xpfe/bootstrap/Makefile.in  6 Dec 2001 22:17:23 -0000       1.149
+++ xpfe/bootstrap/Makefile.in  13 Dec 2001 08:23:27 -0000
@@ -132,6 +132,10 @@
 endif
 endif
 
+ifdef MOZ_SVG
+XP_LIBS                += $(MOZ_LIBART_LIBS)
+endif
+
 ifdef MOZ_ENABLE_GTK
 XP_LIBS                += $(XLDFLAGS) -lXt
 endif

Comment 2

[Brian Ryner (not reading)]

r=bryner

Comment 3

[Alex Fritze]

This might be a stupid question, since I don't know anything about the build 
process on Linux (mind you - or Windows for that matter :-), but why do we have 
to link to libart in xpfe, when it is only being used in layout?

Comment 4

[Bradley Baetz (:bbaetz)]

Andrews noticed this yesterday, and had a patch, but was going to file a bug
when he woke up.

alex: in the static build, everything is linked together, and since libart is a
dynamic library, it needs to have symbols respolved in teh final exe too, not
just the component.

Comment 5

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.7

Comment 6

[hacker formerly known as [e-mail]]

Checking in xpfe/bootstrap/Makefile.in;
/cvsroot/mozilla/xpfe/bootstrap/Makefile.in,v  <--  Makefile.in
new revision: 1.150; previous revision: 1.149
done

Comment 7

[Tracy Walker [:tracy]]

verified checked in