Closed Bug 1150090 Opened 5 years ago Closed 5 years ago
_animation _actors _11 .js | The current Time was updated to -2s
39 bytes, text/x-review-board-request
This test can fail if the test VM is really slow: 1. let state = yield player.getCurrentState(); 2. yield player.setCurrentTime(state.currentTime - 2000); 3. let newState = yield player.getCurrentState(); 4. ok(newState.currentTime < state.currentTime, "The currentTime was updated to -2s"); Line 1 we get the current state of a given css animation and store it. Line 2, we set the currentTime of the animation to be 2s in the past. Line 3, we get the state again and store it. Line 4, we check that the new state's currentTime is less than the previous state's currentTime. Lines 1, 2 and 3 are all async. If the test runs really really slow, then there's a chance that more than 2 seconds have passed between line 2 and 3. We could either subtract more time, but that, eventually, could lead to intermittents too (far fewer though). Or we could pause the animation before starting the test.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
/r/6523 - Bug 1150090 - Intermittent browser_animation_actors_11.js; r=bgrins Pull down this commit: hg pull -r 816c24dccf3bd6781a346839750c7f0273dbc72b https://reviewboard-hg.mozilla.org/gecko/
Attachment #8587231 - Flags: review?(bgrinstead)
Attachment #8587231 - Flags: review?(bgrinstead) → review+
Comment on attachment 8587231 [details] MozReview Request: bz://1150090/pbrosset https://reviewboard.mozilla.org/r/6521/#review5549 Ship It!
You need to log in before you can comment on or make changes to this bug.