Closed Bug 1150109 Opened 9 years ago Closed 9 years ago

[System] System Update Ready message randomly given when update has not been downloaded

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.2 affected, b2g-master affected)

RESOLVED WORKSFORME
blocking-b2g 2.5+
Tracking Status
b2g-v2.2 --- affected
b2g-master --- affected

People

(Reporter: jmitchell, Unassigned)

References

Details

(Keywords: regression, Whiteboard: [3.0-Daily-Testing], [systemsfe])

Attachments

(3 files)

Attached image 2015-04-01-10-02-04.png
Description:
System Update Ready message is being randomly given when a system update is available but has not been downloaded yet.


Repro Steps: (Will be adding Steps-Wanted)

So far this has been seen when turning the device on, and on the lockscreen


Actual: System Update Ready message given

Expected:
System Update message will not be given until system update has been downloaded


Environmental Variables:
Device: Flame 3.0
Build ID: 20150401010204
Gaia: 03164bd160809747e6a198e0dba1b7c3ee7789f5
Gecko: 18a8ea7c2c62
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: Unknown
See attached: screenshot
This has also been seen on a recent 2.2 Build
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Dave can you take a look?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(pbylenga) → needinfo?(dhylands)
I think we'd need a logcat to help out here and check on the phone to see what's in /data/b2g/updates (need to double check that path)
Flags: needinfo?(dhylands)
Although I have seen this issue once yesterday, I am unable to reproduce this issue anymore. I tried to reproduce and find the steps for about an hour, but I was not successful. I got the lockscreen by restarting the device, pressing the power button, and letting the device fall asleep. I also tried with lockscreen code on/off, SIM PIN on/off, and before/after cancelling the system update.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150401010204
Gaia: 03164bd160809747e6a198e0dba1b7c3ee7789f5
Gecko: 18a8ea7c2c62
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Leaving steps wanted keyword for others to try.
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Unfortunately we did not get the very start of the repro on the logcat but hopefully this will help.
I full flashed to previous build, went through FTU, powered cycled phone, and turned on Data.

I only captured the beginning of the download process as Joshua_M provided the ending portion already.

Environmental Variables:
Device: Flame 3.0 Full Flash
Build ID: 20150401085108
Gaia: 4bb3a933bd805e8df1e11827cb247754c3565b0b
Gecko: da2f28836843
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0
[Blocking Requested - why for this release]:
regression, we're forcing a user to download the OTA, seen on Data enabled only.
blocking-b2g: --- → 3.0?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Keywords: regression
OK - this is strange: From the logcat I see:

> 04-01 12:06:52.486   206   206 I Gecko   : *** AUS:SVC UpdateService:_selectAndInstallUpdate - prompting because silent install is disabled
> 04-01 12:06:52.506   206   206 I Gecko   : *** AUS:SVC UpdateService:_selectAndInstallUpdate - add-on compatibility check disabled by preference, just download the update

We have app.update.auto pref set to false https://dxr.mozilla.org/mozilla-central/source/b2g/app/b2g.js#586, so we should ALWAYS see the first log above and NEVER see the second log (due to the hard return).

https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/nsUpdateService.js#2705-2709

I don't see any way that we should ever get both of those logs, except due do to some weird JS bug.

ni? Robert Strong to see if he agrees.
Flags: needinfo?(robert.strong.bugs)
That is bug 1149590 and aurora approval should happen by tomorrow
Flags: needinfo?(robert.strong.bugs)
I did reproduce this issue twice. Seems like this is the STRs:

Pre-requisite: Have a system update available.
1. Turn on the device.
2. Turn on the cell data.
3. Observe the system update available notification.
4. Observe the "System update ready" dialog.

It took me a few minutes to get the dialog after I turn on the cell data. 

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150401010204
Gaia: 03164bd160809747e6a198e0dba1b7c3ee7789f5
Gecko: 18a8ea7c2c62
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Keywords: steps-wanted
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Ahh - I must have been looking at m-c source after the patch landed, which is why things didn't make sense.

I think that the fix for bug 1149590 fixes this one.

So you should see the problem go away with last night's nightly.

There may be a separate issue with downloading over cellular, but that's normally taken care of elsewhere IIRC (i.e. not part of update)
Lets re-test after comment 11.
Keywords: qawanted
We have not seen this issue on Flame 3.0 devices since the week it was written, and I have been unable to purposefully reproduce it, so this may indeed have been fixed by bug 1149590.

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150415095209
Gaia: 2dd89fef4fae4d86fd313037ef384086c2e0e8a5
Gecko: 11077895df62
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: qawanted
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Status: NEW → RESOLVED
blocking-b2g: 3.0? → 3.0+
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: