Make retrigger check for scope login, rather than falling back to Persona thModelErrors

VERIFIED FIXED

Status

Tree Management
Treeherder
P3
minor
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: jfrench, Assigned: jfrench)

Tracking

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
So in bug 1136738 and PR387 we updated the Persona login message, but it doesn't appear to dismiss itself automatically like some other thNotify.send() messsages do.

Use case
o open treeherder while logged out
o select a job
o 'r' to retrigger
o you will get the expected "Please login.." message
o login via Persona

Expected
o the message asynchronously dismisses itself after ~5sec
eg. similar to when Save'ing a classification when logged out, which has a message display style without the [x] close ui

Observed
o the Persona message is persistent
(Assignee)

Comment 1

3 years ago
Created attachment 8586917 [details]
persistentPersonaMsg

Observed per screen grab.
(Assignee)

Comment 3

3 years ago
I think I have a simple fix for the retrigger for James, we just implement a scope thNotify for retrigger. It seems to work, but I just want to test it some more.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Summary: Make the Persona auth-error message transient like other login prompts. → Make retrigger check for scope login, rather than falling back to Persona thModelErrors
(Assignee)

Comment 4

3 years ago
Created attachment 8587691 [details] [review]
treeherder-ui-PR#449

Please see above PR for status and review.
Attachment #8587691 - Flags: review?(emorley)

Updated

3 years ago
Attachment #8587691 - Flags: review?(emorley) → review+

Comment 5

3 years ago
Thank you :-)
(Assignee)

Comment 7

3 years ago
Marking fixed per above merge. I'll verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

3 years ago
Verified fixed on stage.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.