Use moz_xmalloc/moz_xrealloc/free following bug 1134920

RESOLVED FIXED in 1.6

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8587002 [details] [diff] [review]
mozmemfix.diff

Not sure where strdup->xstrdup happened, but it seems to be needed too.
Attachment #8587002 - Flags: review?(clokep)
Comment on attachment 8587002 [details] [diff] [review]
mozmemfix.diff

Review of attachment 8587002 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. Thanks for fixing the build!
Attachment #8587002 - Flags: review?(clokep) → review+
(Assignee)

Comment 3

4 years ago
http://hg.mozilla.org/users/florian_queze.net/purple/rev/cb97b46d6266
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
Hmm...so upon re-reading the newsgroup post it sounds like we're supposed to replace these with just malloc/calloc/realloc/free. [1] (Not the x* versions.)

[1] https://groups.google.com/forum/#!topic/mozilla.dev.platform/ffSQld7olEE
Flags: needinfo?(florian)
(In reply to Patrick Cloke [:clokep] from comment #4)
> we're supposed to replace these with just malloc/calloc/realloc/free.

Yes, please do.
Flags: needinfo?(florian)
You need to log in before you can comment on or make changes to this bug.