Closed Bug 1150230 Opened 6 years ago Closed 6 years ago

Add reading-list.sqlite and about:home indexedDB to SlowSQL whitelist

Categories

(Toolkit :: Telemetry, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: vladan, Assigned: vladan)

Details

Attachments

(1 file)

Attached patch slowsql.patchSplinter Review
Telemetry needs to report slow SQL statements executed against the new reading-list DB.
Added reporting for about:home's indexedDB use as well.
Attachment #8587020 - Flags: review?(dteller)
Comment on attachment 8587020 [details] [diff] [review]
slowsql.patch

Review of attachment 8587020 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Telemetry.cpp
@@ +1829,1 @@
>      "urlclassifier3.sqlite", "webappsstore.sqlite"

Nit: one per line would make it easier to track changes to the list and add individual comments.
Attachment #8587020 - Flags: review?(dteller) → review+
Comment on attachment 8587020 [details] [diff] [review]
slowsql.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1131416
[User impact if declined]: It will be more difficult to evaluate the performance impact of the new Reading List feature
[Describe test coverage new/current, TreeHerder]: Trivial patch
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8587020 - Flags: approval-mozilla-beta?
Attachment #8587020 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/a99ba2338d04
Assignee: nobody → vdjeric
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8587020 [details] [diff] [review]
slowsql.patch

Should be in beta 2
Attachment #8587020 - Flags: approval-mozilla-beta?
Attachment #8587020 - Flags: approval-mozilla-beta+
Attachment #8587020 - Flags: approval-mozilla-aurora?
Attachment #8587020 - Flags: approval-mozilla-aurora+
It would be cool to track all IndexedDB databases... Bug 922898.
You need to log in before you can comment on or make changes to this bug.