Add reading-list.sqlite and about:home indexedDB to SlowSQL whitelist

RESOLVED FIXED in Firefox 38

Status

()

Toolkit
Telemetry
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: vladan, Assigned: vladan)

Tracking

unspecified
mozilla40
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(firefox38 fixed, firefox39 fixed, firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8587020 [details] [diff] [review]
slowsql.patch

Telemetry needs to report slow SQL statements executed against the new reading-list DB.
Added reporting for about:home's indexedDB use as well.
Attachment #8587020 - Flags: review?(dteller)
Comment on attachment 8587020 [details] [diff] [review]
slowsql.patch

Review of attachment 8587020 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Telemetry.cpp
@@ +1829,1 @@
>      "urlclassifier3.sqlite", "webappsstore.sqlite"

Nit: one per line would make it easier to track changes to the list and add individual comments.
Attachment #8587020 - Flags: review?(dteller) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a99ba2338d04
(Assignee)

Comment 3

3 years ago
Comment on attachment 8587020 [details] [diff] [review]
slowsql.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1131416
[User impact if declined]: It will be more difficult to evaluate the performance impact of the new Reading List feature
[Describe test coverage new/current, TreeHerder]: Trivial patch
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8587020 - Flags: approval-mozilla-beta?
Attachment #8587020 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/a99ba2338d04
Assignee: nobody → vdjeric
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
status-firefox38: --- → affected
status-firefox39: --- → affected
Comment on attachment 8587020 [details] [diff] [review]
slowsql.patch

Should be in beta 2
Attachment #8587020 - Flags: approval-mozilla-beta?
Attachment #8587020 - Flags: approval-mozilla-beta+
Attachment #8587020 - Flags: approval-mozilla-aurora?
Attachment #8587020 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/19d2f916667f
status-firefox39: affected → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/88b4ec69e42f
status-firefox38: affected → fixed
It would be cool to track all IndexedDB databases... Bug 922898.
You need to log in before you can comment on or make changes to this bug.