1150230 - Add reading-list.sqlite and about:home indexedDB to SlowSQL whitelist

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

Attachment: slowsql.patch

Telemetry needs to report slow SQL statements executed against the new reading-list DB.
Added reporting for about:home's indexedDB use as well.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8587020 [details] [diff] [review]
slowsql.patch

Review of attachment 8587020 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Telemetry.cpp
@@ +1829,1 @@
>      "urlclassifier3.sqlite", "webappsstore.sqlite"

Nit: one per line would make it easier to track changes to the list and add individual comments.

Comment 2

[Vladan Djeric (:vladan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a99ba2338d04

Comment 3

[Vladan Djeric (:vladan)]

Comment on attachment 8587020 [details] [diff] [review]
slowsql.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1131416
[User impact if declined]: It will be more difficult to evaluate the performance impact of the new Reading List feature
[Describe test coverage new/current, TreeHerder]: Trivial patch
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a99ba2338d04

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8587020 [details] [diff] [review]
slowsql.patch

Should be in beta 2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/19d2f916667f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/88b4ec69e42f

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

It would be cool to track all IndexedDB databases... Bug 922898.