Closed Bug 1150248 Opened 9 years ago Closed 9 years ago

[steeplechase] tests never connect to signaling server

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox40 --- affected

People

(Reporter: drno, Assigned: drno)

Details

A few days ago a lot of our steeplechase WebRTC tests started to fail.

From looking at the signaling server it looks like in these cases usually only one of the two clients ever connects to the signaling server.

Further looking at network traces it appears that the problem is:
index.html loads harness.js and q.min.js. But the code in harness.js has a dependency on q.min.js. Depending on the network, the mood of the web server and the phase of the moon sometimes harness.js is finished loading before q.min.js and in the case the whole things just stalls forever.
If I'm not wrong q.min.js is "only" needed in steeplechase web harness to have an implementation of Promises. So instead of implementing a proper dependency between the two JS files, my idea is to simply remove q.min.js all together and replace it with Firefox's build in Promises: https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Ted: does this idea sound sane, or did I overlook something q.min.js is needed for besides Promises?
Flags: needinfo?(ted)
Assignee: nobody → drno
It's just being used as a Promise polyfill, so I fully support removing it and using ES6 Promises.
Flags: needinfo?(ted)
Merged that PR.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: New Frameworks → General
You need to log in before you can comment on or make changes to this bug.