Closed
Bug 1150266
Opened 9 years ago
Closed 9 years ago
cgen.py contains weird-looking code for emitting function headers
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: jimb, Assigned: froydnj)
Details
Attachments
(1 file)
|
899 bytes,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
At this point in cgen.py: https://hg.mozilla.org/mozilla-central/file/e044f4d172e2/ipc/ipdl/ipdl/cxx/cgen.py#l186 we have the code: if md.inline: self.write('inline ') if md.inline: self.write('MOZ_NEVER_INLINE ') Surely that's not intentional.
|
Reporter | |
Updated•9 years ago
|
Flags: needinfo?(bent.mozilla)
Looks like something went haywire in a merge at some point? Bug 908208 did not have that in the patch I reviewed, but it landed that way...
Flags: needinfo?(bent.mozilla) → needinfo?(nfroyd)
|
Assignee | |
Comment 2•9 years ago
|
||
Um. That's kind of embarrassing. Let me fix that.
Assignee: nobody → nfroyd
Flags: needinfo?(nfroyd)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Whoops.
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8587088 [details] [diff] [review] fix IPDL thinko for never-inline method declarations This is a trivial review...or ought to be.
Attachment #8587088 -
Flags: review?(bent.mozilla)
Comment on attachment 8587088 [details] [diff] [review] fix IPDL thinko for never-inline method declarations Review of attachment 8587088 [details] [diff] [review]: ----------------------------------------------------------------- I blame mercurial... I've seen it do some crazy merges before.
Attachment #8587088 -
Flags: review?(bent.mozilla) → review+
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7d3c3fe8300e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•