1150344 - Fix FxA storage to not require re-reading disk on every request.

Status: RESOLVED DUPLICATE of bug 1157529

(Firefox :: Firefox Accounts, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

Via bug 1139743. getSignedInUserData never caches the user data in memory due to some of the data being locked behind the master-password - we re-read on each request just in-case the MP is now unlocked.

The main issue is really that the AccountState object doesn't know what data is stored where.  Off the top of my head, a solution might be:

* The Storage class grows new methods to separate the reading of "always available" data from the "possibly locked" data.

* The AccountState object then is responsible for calling both of these, and thus can become aware of what bits came from where, and cache them appropriate (eg, it should be able to immediately cache the "always available" data, and then cache the "possibly locked" data once we are able to get it.

* AccountState then returns the merged data with the callers being unaware of the change.

That bug also has many comments for how we can better structure the tests (eg, around bug 1139743 comment 48)

Comment 1

[Edwin Wong [:edwong]]

this is a blocker - setting to P1

Comment 2

[Chris Karlof [:ckarlof]]

:markh, do any of the patches we're working on together make any part of this better?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Chris Karlof [:ckarlof] from comment #2)
> :markh, do any of the patches we're working on together make any part of
> this better?

Yeah, the storage patch fixes this as a side-effect.