d3.js is included twice

RESOLVED FIXED in Firefox 40

Status

()

Firefox
Developer Tools
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: glandium, Assigned: jryans)

Tracking

unspecified
Firefox 40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
d3.js is in modules/devtools/shared/d3.js and chrome/browser/content/browser/devtools/d3.js, once installed from:
  https://dxr.mozilla.org/mozilla-central/source/browser/devtools/jar.mn#82
and another from:
  https://dxr.mozilla.org/mozilla-central/source/browser/devtools/shared/moz.build#50

It seems it's only used through the chrome://browser/content/devtools/d3.js url, and never through resource://app/modules/devtools/shared/d3.js or resource:///modules/devtools/shared/d3.js

OTOH, looking at a few of the other files installed in modules/devtools/shared in the same moz.build, I see none being referenced in some other file, so I'd rather someone who knows this code look instead.

[ Kind of relatedly, d3.js's license is not included ]
The modules paths typically are used indirectly via require in DevTools, but d3 doesn't seem used[1] that way.

So, it seems safe to remove the modules one to me.

As for the license, it seems the full discussion got lost when it originally landed (see bug 980503 comment 7).

[1]: https://dxr.mozilla.org/mozilla-central/search?q=devtools%2Fshared%2F&case=true
I see the license files in browser/toolkit/webaudioeditor/lib/, but the common procedure is to put them in toolkit/content/license.html (and ask gerv for review).
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Created attachment 8588567 [details] [diff] [review]
0001-Bug-1150366-Remove-duplicate-d3.js.-r-jsantell.patch
Attachment #8588567 - Flags: review?(jsantell)
Created attachment 8588568 [details] [diff] [review]
0002-Bug-1150366-Fix-license.html-line-endings.-r-gerv.patch
Attachment #8588568 - Flags: review?(gerv)
Created attachment 8588569 [details] [diff] [review]
0003-Bug-1150366-Add-D3-licenses-to-license.html.-r-gerv.patch
Attachment #8588569 - Flags: review?(gerv)
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e495709444d

(To check the file removal in part 1.)
Attachment #8588567 - Flags: review?(jsantell) → review+
Attachment #8588568 - Flags: review?(gerv) → review+
Attachment #8588569 - Flags: review?(gerv) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/0aed01897af1
https://hg.mozilla.org/integration/fx-team/rev/43ac0f493dbe
https://hg.mozilla.org/integration/fx-team/rev/7d76602633a6
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/0aed01897af1
https://hg.mozilla.org/mozilla-central/rev/43ac0f493dbe
https://hg.mozilla.org/mozilla-central/rev/7d76602633a6
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.