1150372 - Add nfc feature checkbox in App Minimum Requirements

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, enhancement, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

When I submit an NFC App to marketplace, I notice that in the "App Minimimum Requirements" section, there's no checkbox for NFC API. (NFC becomes priviledge in Bug 1082475).

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi mat
Do you know where the code is?
I cannot find it.   :P

Thanks

Comment 2

[Mathieu Pillard [:mat]]

The code that will make the checkbox appear is in https://github.com/mozilla/zamboni/ , mainly in mkt/constants/features.py

Couple gotchas:
- You also need to bump the APP_FEATURES_VERSION number in settings

- You also need to detect that feature in Marketplace consumer side, which can be tricky to do if you are not familiar with that code. It lives in https://github.com/mozilla/fireplace/ , mainly in package/iframe/main.js and in src/media/js/compat_filter.js

Comment 3

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/3026 will take care of the zamboni part

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/a3084805bc2ab014abbc73d3532f5ec269aa661b (will land in production next Tuesday)

The consumer pages side isn't done yet (need to file another bug for that), but at least the developers will be able to set the feature requirement.

Comment 5

[Madalin Cotetiu]

Verified as fixed in FF40(Win7) in marketplace-dev.allizom.org
Postfix screencast: http://screencast.com/t/teL1tpqk  http://screencast.com/t/NNGgujrk
Closing bug.