[Stingray] Add data access methods to supporting folder operation

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: dwi2, Assigned: dwi2)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We need to add these methods:

1. updateCard
2. swapCard
3. getCardListOfFolder (similar to getCardList() in CardManager)
4. findCardFromFolder (similar to findCardFromCardList() in CardManager)
(Assignee)

Updated

4 years ago
Summary: [Stingray] Add data access method for supporting folder → [Stingray] Add data access methods to supporting folder operation
(Assignee)

Updated

4 years ago
Assignee: nobody → tzhuang
Created attachment 8589010 [details] [review]
[gaia] dwi2:bug1150419 > mozilla-b2g:master
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Comment on attachment 8589010 [details] [review]
[gaia] dwi2:bug1150419 > mozilla-b2g:master

Hi Rex,

Please help to review the patch, thanks.

We add four methods in folder.js to support folder operation:
1. getCardList
2. findCard
3. updateCard
4. swapCard
Attachment #8589010 - Flags: review?(rexboy)
Comment on attachment 8589010 [details] [review]
[gaia] dwi2:bug1150419 > mozilla-b2g:master

Looks ok to me but I think we need to add some events specifying the updated card in Folder. Please see my comments and add them before landing.
Attachment #8589010 - Flags: review?(rexboy) → review+
(Assignee)

Comment 4

4 years ago
Thanks. All comments are addressed.
(Assignee)

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#8zHTabgmTKe3VWfo_W-iFg

The pull request failed to pass integration tests. It could not be landed, please try again.
(Assignee)

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 1153107
Whiteboard: [partner-cherry-pick]

Updated

3 years ago
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.