Closed
Bug 1150419
Opened 9 years ago
Closed 9 years ago
[Stingray] Add data access methods to supporting folder operation
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: dwi2)
References
Details
Attachments
(1 file)
We need to add these methods: 1. updateCard 2. swapCard 3. getCardListOfFolder (similar to getCardList() in CardManager) 4. findCardFromFolder (similar to findCardFromCardList() in CardManager)
Assignee | ||
Updated•9 years ago
|
Summary: [Stingray] Add data access method for supporting folder → [Stingray] Add data access methods to supporting folder operation
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → tzhuang
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8589010 [details] [review] [gaia] dwi2:bug1150419 > mozilla-b2g:master Hi Rex, Please help to review the patch, thanks. We add four methods in folder.js to support folder operation: 1. getCardList 2. findCard 3. updateCard 4. swapCard
Attachment #8589010 -
Flags: review?(rexboy)
Comment 3•9 years ago
|
||
Comment on attachment 8589010 [details] [review] [gaia] dwi2:bug1150419 > mozilla-b2g:master Looks ok to me but I think we need to add some events specifying the updated card in Folder. Please see my comments and add them before landing.
Attachment #8589010 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Thanks. All comments are addressed.
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#8zHTabgmTKe3VWfo_W-iFg The pull request failed to pass integration tests. It could not be landed, please try again.
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/eaf69e651e19b98c096f8e63b9829fb31df50927
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
You need to log in
before you can comment on or make changes to this bug.
Description
•