1150476 - Unordered lists are displayed as ordered lists

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect)

Description

[Alex Gibson [:agibson]]

STR:

1.) In Nightly, visit: http://alistapart.com/article/taminglists/#figure1
2.) Click the Reader View icon in the address bar.
3.) In Reader View scroll down to #figure1

Expected results:

The unordered list items should be preceded by a disc.

Actual Results:

The unordered list items and ordered numerically.

As pointed out in the original GitHub issue I opened [1], it looks lime there is a typo in the Reader View CSS style sheet:

.content ul {
    list-style: outside none disk;
}

should in fact be:

.content ul {
    list-style: outside none disc;
}

[1] https://github.com/mozilla/readability/issues/93

Comment 1

[:Gijs (he/him)]

I was cheeky and just landed this because, srsly. :-)

remote:   https://hg.mozilla.org/integration/fx-team/rev/19c7476c47de

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/19c7476c47de

Comment 3

[:Margaret Leibovic]

Attachment: fix silly typo in list styles

Approval Request Comment
[Feature/regressing bug #]: reader view
[User impact if declined]: wrong bullet styles in reader view
[Describe test coverage new/current, TreeHerder]: landed on nightly
[Risks and why]: low-risk simple CSS change
[String/UUID change made/needed]: none

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8588100 [details] [diff] [review]
fix silly typo in list styles

should be in 38 beta 2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bd0bf4503443

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3d380257da88