Closed Bug 1150476 Opened 5 years ago Closed 5 years ago

Unordered lists are displayed as ordered lists

Categories

(Toolkit :: Reader Mode, defect)

defect
Not set
Points:
1

Tracking

()

RESOLVED FIXED
mozilla40
Iteration:
40.1 - 13 Apr
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: agibson, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STR:

1.) In Nightly, visit: http://alistapart.com/article/taminglists/#figure1
2.) Click the Reader View icon in the address bar.
3.) In Reader View scroll down to #figure1

Expected results:

The unordered list items should be preceded by a disc.

Actual Results:

The unordered list items and ordered numerically.

As pointed out in the original GitHub issue I opened [1], it looks lime there is a typo in the Reader View CSS style sheet:

.content ul {
    list-style: outside none disk;
}

should in fact be:

.content ul {
    list-style: outside none disc;
}

[1] https://github.com/mozilla/readability/issues/93
I was cheeky and just landed this because, srsly. :-)

remote:   https://hg.mozilla.org/integration/fx-team/rev/19c7476c47de
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 40.1 - 13 Apr
Points: --- → 1
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
Hardware: x86 → All
Blocks: 1132074
https://hg.mozilla.org/mozilla-central/rev/19c7476c47de
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Approval Request Comment
[Feature/regressing bug #]: reader view
[User impact if declined]: wrong bullet styles in reader view
[Describe test coverage new/current, TreeHerder]: landed on nightly
[Risks and why]: low-risk simple CSS change
[String/UUID change made/needed]: none
Attachment #8588100 - Flags: approval-mozilla-beta?
Attachment #8588100 - Flags: approval-mozilla-aurora?
Comment on attachment 8588100 [details] [diff] [review]
fix silly typo in list styles

should be in 38 beta 2
Attachment #8588100 - Flags: approval-mozilla-beta?
Attachment #8588100 - Flags: approval-mozilla-beta+
Attachment #8588100 - Flags: approval-mozilla-aurora?
Attachment #8588100 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.