Closed Bug 1150538 Opened 8 years ago Closed 7 years ago

include comment (and maybe other parts of rule) in delete confirmation dialog

Categories

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (frontend)
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: njirap, Mentored)

Details

(Whiteboard: [lang=js]) 

      No description provided.
Mentor: bhearsum
Whiteboard: [lang=js]
This is getting fixed in https://github.com/mozilla/balrog-ui/pull/18, which should go to production in the next week.
Commits pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/30eb2c8f91f45687d958a3d2fe1f86fed97a8b10
[rule-delete-modal] Added comment and other Rule information

Closes-bug: #1150538

https://github.com/mozilla/balrog/commit/8a40e96b2dcf6fa015b50a22f4d002e39160ba7e
[rule-delete-modal] Added rule comment

Closes-bug: #1150538

https://github.com/mozilla/balrog/commit/064129d7b04e5ff15c4bb283a21eba76e0bdb58a
[rule-delete-modal] Added rule comment

Closes-bug: #1150538

https://github.com/mozilla/balrog/commit/fc73e32b499617c0c0d0c2640f082ff46d6b73d4
Merge pull request #57 from njirap/master

bug 1150538: include comment in delete confirmation dialog. r=bhearsum
njirap has a fix for this, it's just waiting to get pushed to production.
Assignee: nobody → njirap
This landed in production today. Thanks for the patch!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/b49c9ad48daeb01ebb757186b0b9aaec81e4a961
[balrog-ui] [rule-delete-modal] Added comment and other Rule information

Closes-bug: #1150538

https://github.com/mozilla/balrog/commit/f27ed9f5bba28247a55b1bd1a316cfea5088a7f8
[balrog-ui] [rule-delete-modal] Added rule comment

Closes-bug: #1150538
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.