1150578 - Adjust new devtools theme colors and palette on wiki

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Brian Grinstead [:bgrins]]

Once we land the new colors in 947242, we should make any necessary adjustments to the color palette also update the wiki at the same time https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors.

Comment 1

[Brian Grinstead [:bgrins]]

I have a suggestion in https://bugzilla.mozilla.org/show_bug.cgi?id=947242#c42 to update this color:

Light theme (Blue Grey) from #5f88b0 to #0072AB

Not stuck on the particular color we change to, but I think anything in that direction is an improvement.  See the screenshot: https://bug947242.bugzilla.mozilla.org/attachment.cgi?id=8475326.

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Setting devedition-40 bugs to p3, filter on FB20EAC4-3FC3-48D9-B15F-0587C3987C25

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: perf dark theme

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: perf light theme

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

With the colors documented on MDN landing in the actual tools' CSS in bug 947242, and the performance graphs now utilizing the colors defined there, we get some weird results. While I prefer the new colors for the text and highlights in most tools, they seem a bit bold/dark when used in our performance renderings and graphs. See the two attachments.

Dark looks pretty good, IMO, but light has the bold/dark look to it. Would it make sense to have a new set of colors, one for text, one for highlights like this? For example, I'd like many of the light theme "highlight" colors to be brighter, but that'd make all the text using these colors pretty hard to read.

Some of these graphs are shipping soon in Fx40, so we'll have to figure out something soon!

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Adding new colors in bug 1164552 for performance graphs -- can change or add to wiki in the future, but this needs done for 40.1. Clearing ni?

Comment 7

[Brian Grinstead [:bgrins]]

Stephen, can you take a quick look at https://bug947242.bugzilla.mozilla.org/attachment.cgi?id=8475326 and confirm that the suggested color change is good?

Comment 8

[Brian Grinstead [:bgrins]]

Attachment: bluegrey.patch

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d4a898d5ce9

Comment 10

[Brian Grinstead [:bgrins]]

(In reply to Gabriel Luong [:gl] from comment #9)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d4a898d5ce9

Correct try link is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf7877e9a18a

Comment 11

[Stephen Horlander [:shorlander]]

(In reply to Brian Grinstead [:bgrins] from comment #7)
> Stephen, can you take a quick look at
> https://bug947242.bugzilla.mozilla.org/attachment.cgi?id=8475326 and confirm
> that the suggested color change is good?

Maybe a little close to the other blue, but it's definitely easier to read.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/69d9848dd6a5

Comment 13

[Gabriel Luong [:gl] (ΦωΦ)]

We want to file a bug to address the color of the attributes since the new color is a bit close to the blue in the attributes. @shorlander was okay with the changes to land for now.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/69d9848dd6a5

Comment 15

[Brian Grinstead [:bgrins]]

Updated https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors with the new color