Closed Bug 1150578 Opened 6 years ago Closed 6 years ago

Adjust new devtools theme colors and palette on wiki

Categories

(DevTools :: Framework, defect, P3)

x86
macOS
defect

Tracking

(firefox42 fixed)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [polish-backlog])

Attachments

(3 files)

Once we land the new colors in 947242, we should make any necessary adjustments to the color palette also update the wiki at the same time https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors.
I have a suggestion in https://bugzilla.mozilla.org/show_bug.cgi?id=947242#c42 to update this color:

Light theme (Blue Grey) from #5f88b0 to #0072AB

Not stuck on the particular color we change to, but I think anything in that direction is an improvement.  See the screenshot: https://bug947242.bugzilla.mozilla.org/attachment.cgi?id=8475326.
Whiteboard: [devedition-40]
Setting devedition-40 bugs to p3, filter on FB20EAC4-3FC3-48D9-B15F-0587C3987C25
Priority: -- → P3
With the colors documented on MDN landing in the actual tools' CSS in bug 947242, and the performance graphs now utilizing the colors defined there, we get some weird results. While I prefer the new colors for the text and highlights in most tools, they seem a bit bold/dark when used in our performance renderings and graphs. See the two attachments.

Dark looks pretty good, IMO, but light has the bold/dark look to it. Would it make sense to have a new set of colors, one for text, one for highlights like this? For example, I'd like many of the light theme "highlight" colors to be brighter, but that'd make all the text using these colors pretty hard to read.

Some of these graphs are shipping soon in Fx40, so we'll have to figure out something soon!
Flags: needinfo?(shorlander)
Adding new colors in bug 1164552 for performance graphs -- can change or add to wiki in the future, but this needs done for 40.1. Clearing ni?
Flags: needinfo?(shorlander)
Stephen, can you take a quick look at https://bug947242.bugzilla.mozilla.org/attachment.cgi?id=8475326 and confirm that the suggested color change is good?
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Flags: needinfo?(shorlander)
Attached patch bluegrey.patchSplinter Review
Attachment #8628537 - Flags: review?(gabriel.luong)
(In reply to Brian Grinstead [:bgrins] from comment #7)
> Stephen, can you take a quick look at
> https://bug947242.bugzilla.mozilla.org/attachment.cgi?id=8475326 and confirm
> that the suggested color change is good?

Maybe a little close to the other blue, but it's definitely easier to read.
Flags: needinfo?(shorlander)
Attachment #8628537 - Flags: review?(gabriel.luong) → review+
We want to file a bug to address the color of the attributes since the new color is a bit close to the blue in the attributes. @shorlander was okay with the changes to land for now.
https://hg.mozilla.org/mozilla-central/rev/69d9848dd6a5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Whiteboard: [devedition-40] → [polish-backlog]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.