[Customizer] Lazy-load the Customizer

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: justindarc, Assigned: justindarc)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [spark])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
In order to prevent the Customizer from using resources before it has been invoked, the bulk of the JS should be loaded lazily upon first invocation.
(Assignee)

Updated

3 years ago
Blocks: 1133943
(Assignee)

Updated

3 years ago
Assignee: nobody → jdarcangelo
(Assignee)

Comment 1

3 years ago
Created attachment 8588078 [details] [review]
WIP pull-request (master)

This is just part one. I moved all the controller/view initialization over to the MainController. Should make things easier to lazy-load now.
Attachment #8588078 - Flags: review?(drs)
Comment on attachment 8588078 [details] [review]
WIP pull-request (master)

r- due only to the init marking pattern used. I left some other comments that are mostly just thinking out loud about where we are.
Attachment #8588078 - Flags: review?(drs) → review-
(Assignee)

Updated

3 years ago
Depends on: 1151586
(Assignee)

Comment 3

3 years ago
Created attachment 8590950 [details] [review]
pull-request (master)

This is an updated version of the PR that actually lazy-evals the WCs. It also addresses your previous comments about dealing with the promise flag.
Attachment #8588078 - Attachment is obsolete: true
Attachment #8590950 - Flags: review?(drs)
Comment on attachment 8590950 [details] [review]
pull-request (master)

Looks good. I left some comments, but none of them are important to fix.
Attachment #8590950 - Flags: review?(drs) → review+
(Assignee)

Comment 5

3 years ago
Addressed comments and landed on master:

https://github.com/fxos/customizer/commit/be6c670b9375f4659485da099365d85de91c6283
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [spark]
You need to log in before you can comment on or make changes to this bug.