1150646 - INFO MEMORY STAT logging no longer displayed in TreeHerder raw logs for mochitests

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Shu-yu Guo [:shu]]

A while ago we added printing of memory information after every mochitest. They look something like the following.

75 INFO MEMORY STAT vsize after test: 892674048
76 INFO MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
77 INFO MEMORY STAT residentFast after test: 324292608
78 INFO MEMORY STAT heapAllocated after test: 84140968

The raw logs on TH no longer has these, though if I run a mochitest locally I see them.

Comment 1

[Shu-yu Guo [:shu]]

Hi Chris, I was told you're the person to talk to about possible logging issues?

Comment 2

[Chris Manchester (limited bugmail, email directly)]

I think that's suppressed intentionally (along with a bunch of other output from tests at some point deemed mundane). I can probably figure out how to turn it back on. Are you intending to do this on try to debug a one off issue, or do we want this on for everything?

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Remove some unused nsIProgrammingLanguage.h includes.

The XPCOM.h one is the most dangerous.  For the other ones, I just checked that those files don't refer to nsIProgrammingLanguae anywhere. (The file only contains a few constants of the form nsIProgrammingLanguage::)

Comment 4

[Andrew McCreight [:mccr8]]

Oops, wrong bug.

Comment 5

[Andrew McCreight [:mccr8]]

(In reply to Chris Manchester [:chmanchester] from comment #2)
> Are you intending to do this on try to debug a one off
> issue, or do we want this on for everything?

This is needed on an ongoing basis in order to let people see how close we are to OOMing during tests.  Previously, a variety of leaks and issues came together to result in a multi-day tree closure.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Or quasi-intentionally. Replacing logger.info with dump in MemoryStats.dump should do it. Running mach with --quiet will give you the output you see on treeherder.

Comment 7

[Tom Tromey :tromey]

Attachment: ensure that memory stats show up in treeherder logs

I did this in a bit of a funny way to provide a spot to comment why
"logger" isn't used.

Comment 8

[Shu-yu Guo [:shu]]

100% what mccr8 said.

Comment 9

[Andrew McCreight [:mccr8]]

More concretely, the use case is that we start getting weird crashes, then the sheriffs can poke around in the log to see if memory usage is crazy high or not, and then hopefully find somebody to investigate before we get to the point of crisis which closes the tree.

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8587623 [details] [diff] [review]
ensure that memory stats show up in treeherder logs

Review of attachment 8587623 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/tests/SimpleTest/MemoryStats.js
@@ +54,3 @@
>  }
>  
>  MemoryStats.dump = function (logger,

Optionally also get rid of this parameter now that it's not used.

Comment 11

[Tom Tromey :tromey]

Attachment: ensure that memory stats show up in treeherder logs

This version removes the parameter.  Re-requesting review since it's a
reasonably significant change.

Comment 12

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=42b9ca8316e1

Comment 13

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8587990 [details] [diff] [review]
ensure that memory stats show up in treeherder logs

Review of attachment 8587990 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this. r=me with a fix for mochitest-plain.

::: testing/mochitest/tests/SimpleTest/MemoryStats.js
@@ +59,5 @@
>                               dumpAboutMemory,
>                               dumpDMD) {
> +    // Use dump because treeherder uses --quiet, which drops 'info'
> +    // from the structured logger.
> +    let info = function(message) {

This needs to be "var" for mochitest-plain unless we also change the tags that include the script.

Comment 14

[Tom Tromey :tromey]

Attachment: ensure that memory stats show up in treeherder logs

s/let/var/ - thanks

Comment 15

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d099eadb1740

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7b56aed5164

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e7b56aed5164

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cc5bf3663f50
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/23214f805a5c

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fa0e7f6203a0

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a1d7b2cdd950

Comment 21

[Vincent Liu[:vliu]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/23214f805a5c