Closed Bug 1150707 Opened 6 years ago Closed 6 years ago

Make use of tags for running only icaljs/libcal tests

Categories

(Calendar :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

bug 987360 added a tags property which will help us run only icaljs tests, or only libical tests.

Usage:

mach xpcshell-test --tags icaljs  # run only ical.js tests
mach xpcshell-test --tags libical # run only libical tests

The patch here will not work until they switch to space delimiters, which should happen soon enough that its ok to push this.

For a brief moment I thought about adding more tags like "alarms" to specific tests, but given our tests run fairly fast I'm not sure how useful that would be. It might tempt to just run tests partially when writing patches.
Attached patch Fix - v1 β€” β€” Splinter Review
Attachment #8587667 - Flags: review?(geoff)
Comment on attachment 8587667 [details] [diff] [review]
Fix - v1

Nice. I've been wanting this for some time.
Attachment #8587667 - Flags: review?(geoff) → review+
Pushed to comm-central changeset 4d54b17e9075
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.1
Target Milestone: 4.1 → 4.2
You need to log in before you can comment on or make changes to this bug.